Issue 18209003: Don't use the identifiers TRUE and FALSE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18209003: Don't use the identifiers TRUE and FALSE (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 5 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Don't use the identifiers TRUE and FALSE icu uses the same identifiers, so we can't just #undef them BUG=v8:2745 R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15565

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -16 lines)			Patch
M	src/jsregexp.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/jsregexp.cc	View	8 chunks	+16 lines, -12 lines	0 comments	Download
M	src/win32-headers.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Yang

On 2013/07/08 15:14:56, jochen wrote: Can we rename it to TRUE_VALUE and FALSE_VALUE instead of ...

7 years, 5 months ago (2013-07-08 15:22:46 UTC) #2

jochen (gone - plz use gerrit)

7 years, 5 months ago (2013-07-09 07:19:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15565 (presubmit successful).