Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1820893003: fix svg test expectation (Closed)

Created:
4 years, 9 months ago by caryclark
Modified:
4 years, 9 months ago
Reviewers:
f(malita)
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fix svg test expectation Change SVG test to values generated after fixing the generation of zero length dash intervals. The SVG test svg/W3C-SVG-1.1/painting-stroke-04-t.svg was suppressed in commit d886bedb1e41ad07d2f5028c614bb70c88f5c5a0t R=fmalita@chromium.org BUG=591993 Committed: https://crrev.com/7b7c6041ba1bdcf39ca2078ad864ded906209f5a Cr-Commit-Position: refs/heads/master@{#382386}

Patch Set 1 #

Patch Set 2 : just ask the machine to do the work for me #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
caryclark
4 years, 9 months ago (2016-03-21 18:57:20 UTC) #1
f(malita)
It's tricky to get these right on all platforms, can you change the expectation from ...
4 years, 9 months ago (2016-03-21 19:02:46 UTC) #2
caryclark
On 2016/03/21 19:02:46, f(malita) wrote: > It's tricky to get these right on all platforms, ...
4 years, 9 months ago (2016-03-21 19:29:14 UTC) #3
f(malita)
lgtm
4 years, 9 months ago (2016-03-21 19:35:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820893003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820893003/20001
4 years, 9 months ago (2016-03-21 19:54:39 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 21:04:32 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 21:05:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b7c6041ba1bdcf39ca2078ad864ded906209f5a
Cr-Commit-Position: refs/heads/master@{#382386}

Powered by Google App Engine
This is Rietveld 408576698