Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1820883002:
Correct comment to refer to SkImageFilter::kReverse_MapDirection. (Closed)
DescriptionCorrect comment to refer to SkImageFilter::kReverse_MapDirection.
kBackward_MapDirection does not exist; might as well have the comment exactly
match the valid enumerator.
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820883002
Committed: https://skia.googlesource.com/skia/+/127fe3e24b488b7cf67308e791847ee229012862
Patch Set 1 #
Messages
Total messages: 19 (9 generated)
Description was changed from ========== Correct comment to refer to SkImageFilter::kReverse_MapDirection. kBackward_MapDirection does not exist; might as well have the comment exactly match the valid enumerator. ========== to ========== Correct comment to refer to SkImageFilter::kReverse_MapDirection. kBackward_MapDirection does not exist; might as well have the comment exactly match the valid enumerator. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
jbroman@chromium.org changed reviewers: + robertphillips@google.com, senorblanco@chromium.org
Probably just a minor oversight, but this briefly confused me when I was trying to call this member.
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820883002/1
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2016-03-21 20:42 UTC
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jbroman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820883002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
Description was changed from ========== Correct comment to refer to SkImageFilter::kReverse_MapDirection. kBackward_MapDirection does not exist; might as well have the comment exactly match the valid enumerator. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Correct comment to refer to SkImageFilter::kReverse_MapDirection. kBackward_MapDirection does not exist; might as well have the comment exactly match the valid enumerator. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
TBRing reed because this is not a public API change
The CQ bit was checked by jbroman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820883002/1
Message was sent while issue was closed.
Description was changed from ========== Correct comment to refer to SkImageFilter::kReverse_MapDirection. kBackward_MapDirection does not exist; might as well have the comment exactly match the valid enumerator. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Correct comment to refer to SkImageFilter::kReverse_MapDirection. kBackward_MapDirection does not exist; might as well have the comment exactly match the valid enumerator. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/127fe3e24b488b7cf67308e791847ee229012862 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/127fe3e24b488b7cf67308e791847ee229012862 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
