Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: push/go/push/main.go

Issue 1820863002: Update callers of httputils.ReportError to specify message (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Remove taskID Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « go/httputils/http.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: push/go/push/main.go
diff --git a/push/go/push/main.go b/push/go/push/main.go
index 1466e1f7f1bc149d1b728fa728e3ecd7d1bf6a04..08ac2b2ec7500ee598c33bb2202a166d7fadd427 100644
--- a/push/go/push/main.go
+++ b/push/go/push/main.go
@@ -372,7 +372,7 @@ func stateHandler(w http.ResponseWriter, r *http.Request) {
if r.Method == "POST" {
if login.LoggedInAs(r) == "" {
- httputils.ReportError(w, r, fmt.Errorf("You must be logged on to push."), "")
+ httputils.ReportError(w, r, nil, "You must be logged on to push.")
return
}
push := PushNewPackage{}
@@ -463,7 +463,7 @@ func statusHandler(w http.ResponseWriter, r *http.Request) {
// running on the machine hosting that service.
func changeHandler(w http.ResponseWriter, r *http.Request) {
if login.LoggedInAs(r) == "" {
- httputils.ReportError(w, r, fmt.Errorf("You must be logged on to push."), "")
+ httputils.ReportError(w, r, nil, "You must be logged on to push.")
return
}
if err := r.ParseForm(); err != nil {
« no previous file with comments | « go/httputils/http.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698