Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 1820823002: Update V8 DEPS. (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update V8 DEPS. Rolling v8/build/gyp to 133eaf70b3720b7413017ef3f9c42f6811ef9347 Rolling v8/third_party/icu to 0d572d65aae621e13d6863fe470c9c8cee71043d This is the same as the auto-generated version, but with a landmine: https://codereview.chromium.org/1824563002/ TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Committed: https://crrev.com/1d6dba43c2b61900be68777297634e05d479a25a Cr-Commit-Position: refs/heads/master@{#34914} patch from issue 1824563002 at patchset 1 (http://crrev.com/1824563002#ps1) BUG= Committed: https://crrev.com/741ec0110776cebb4b99b36025389c5a4990c69c Cr-Commit-Position: refs/heads/master@{#34921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M build/get_landmines.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820823002/1
4 years, 9 months ago (2016-03-21 08:34:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 08:56:28 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 08:57:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/741ec0110776cebb4b99b36025389c5a4990c69c
Cr-Commit-Position: refs/heads/master@{#34921}

Powered by Google App Engine
This is Rietveld 408576698