Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1456)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1820793005: gpu_host_messages => content/common (Closed)

Created:
4 years, 9 months ago by Fady Samuel
Modified:
4 years, 9 months ago
Reviewers:
dcheng, piman
CC:
brettw, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org, nona+watch_chromium.org, piman+watch_chromium.org, shuchen+watch_chromium.org, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu_host_messages => content/common content/browser cannot depend on content/gpu because that pulls in blink. Thus, this CL moves gpu_host_messages.h and dependencies to content/common BUG=596935 Committed: https://crrev.com/115b5ed455b9d00ed278e5138e29bee2402ee32b Cr-Commit-Position: refs/heads/master@{#382648}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -412 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/content_message_generator.h View 1 chunk +1 line, -0 lines 0 comments Download
A + content/common/establish_channel_params.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/common/establish_channel_params.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/common/gpu_host_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 3 chunks +3 lines, -1 line 0 comments Download
M content/content_gpu.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M content/gpu/BUILD.gn View 1 chunk +0 lines, -5 lines 2 comments Download
D content/gpu/content_gpu_message_generator.h View 1 chunk +0 lines, -7 lines 0 comments Download
D content/gpu/content_gpu_message_generator.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D content/gpu/establish_channel_params.h View 1 chunk +0 lines, -27 lines 0 comments Download
D content/gpu/establish_channel_params.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D content/gpu/gpu_host_messages.h View 1 chunk +0 lines, -299 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820793005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820793005/1
4 years, 9 months ago (2016-03-22 17:51:53 UTC) #2
Fady Samuel
piman@ for overall review. dcheng@ for messages.
4 years, 9 months ago (2016-03-22 17:51:55 UTC) #4
Fady Samuel
jam@, brettw@ in CC: FYI this CL addresses the indirect blink dependency issue from content/browser ...
4 years, 9 months ago (2016-03-22 18:04:48 UTC) #6
piman
lgtm
4 years, 9 months ago (2016-03-22 18:29:28 UTC) #7
dcheng
lgtm https://codereview.chromium.org/1820793005/diff/1/content/gpu/BUILD.gn File content/gpu/BUILD.gn (left): https://codereview.chromium.org/1820793005/diff/1/content/gpu/BUILD.gn#oldcode31 content/gpu/BUILD.gn:31: "establlish_channel_params.h", Huh. I'm surprised this typo didn't cause ...
4 years, 9 months ago (2016-03-22 18:31:26 UTC) #8
Fady Samuel
CQ'ing. https://codereview.chromium.org/1820793005/diff/1/content/gpu/BUILD.gn File content/gpu/BUILD.gn (left): https://codereview.chromium.org/1820793005/diff/1/content/gpu/BUILD.gn#oldcode31 content/gpu/BUILD.gn:31: "establlish_channel_params.h", On 2016/03/22 18:31:26, dcheng wrote: > Huh. ...
4 years, 9 months ago (2016-03-22 18:46:31 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 19:32:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820793005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820793005/1
4 years, 9 months ago (2016-03-22 19:35:02 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 19:42:09 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 19:44:28 UTC) #19
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/115b5ed455b9d00ed278e5138e29bee2402ee32b
Cr-Commit-Position: refs/heads/master@{#382648}

Powered by Google App Engine
This is Rietveld 408576698