third_party/WebKit/Source/core/style/ComputedStyle.cpp - Issue 1820773002: getComputedStyle() should return used value for 'line-height'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 1820773002: getComputedStyle() should return used value for 'line-height' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

index 49e5bca26b5b1d39c7d3d9b8dae61153600f3f2f..2ca7c57ec93743b3473ab8dc85190301c7328ae6 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

@@ -1352,7 +1352,7 @@ Length ComputedStyle::lineHeight() const

void ComputedStyle::setLineHeight(const Length& specifiedLineHeight) { SET_VAR(inherited, line_height, specifiedLineHeight); }

-int ComputedStyle::computedLineHeight() const

+float ComputedStyle::computedLineHeight() const

{

const Length& lh = lineHeight();

« third_party/WebKit/Source/core/style/ComputedStyle.h ('K') | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | no next file » | no next file with comments »