third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 1820773002: getComputedStyle() should return used value for 'line-height'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 1820773002: getComputedStyle() should return used value for 'line-height' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt ('k') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index 098c11f63e382eb7aacbf9ab8cdc2a79368075b0..26f7e40714e0ee32d4b688a77fc27252b3d88913 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -461,11 +461,7 @@ static RawPtr<CSSValueList> valueForContentPositionAndDistributionWithOverflowAl

static RawPtr<CSSPrimitiveValue> valueForLineHeight(const ComputedStyle& style)

{

- Length length = style.lineHeight();

- if (length.isNegative())

- return cssValuePool().createIdentifierValue(CSSValueNormal);

- return zoomAdjustedPixelValue(floatValueForLength(length, style.getFontDescription().computedSize()), style);

+ return zoomAdjustedPixelValue(style.computedLineHeight(), style);

}

static CSSValueID identifierForFamily(const AtomicString& family)