third_party/WebKit/LayoutTests/fast/css/font-shorthand-line-height.html - Issue 1820773002: getComputedStyle() should return used value for 'line-height'

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css/font-shorthand-line-height.html

Issue 1820773002: getComputedStyle() should return used value for 'line-height' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/font-shorthand-from-longhands-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/css/font-shorthand-line-height-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/js-test.js"></script>	2 <script src="../../resources/js-test.js"></script>

3 <style>	3 <style>

4 #system_font_1 { font: caption; line-height: 100px; }	4 #system_font_1 { font: caption; line-height: 100px; }

5 #system_font_2 { line-height: 100px; font: caption; }	5 #system_font_2 { line-height: 100px; font: caption; }

6	6

7 #shorthand_normal_1 { font: 10px monospace; line-height: 100px; }	7 #shorthand_normal_1 { font: 10px monospace; line-height: 100px; }

8 #shorthand_normal_2 { line-height: 100px; font: 10px monospace; }	8 #shorthand_normal_2 { line-height: 100px; font: 10px monospace; }

9	9

10 #shorthand_line_height_1 { font: 10px/200px monospace; line-height: 100px; }	10 #shorthand_line_height_1 { font: 10px/200px monospace; line-height: 100px; }

11 #shorthand_line_height_2 { line-height: 100px; font: 10px/200px monospace; }	11 #shorthand_line_height_2 { line-height: 100px; font: 10px/200px monospace; }

12 </style>	12 </style>

13 <div id="system_font_1"></div>	13 <div id="system_font_1"></div>

14 <div id="system_font_2"></div>	14 <div id="system_font_2"></div>

15 <div id="shorthand_normal_1"></div>	15 <div id="shorthand_normal_1"></div>

16 <div id="shorthand_normal_2"></div>	16 <div id="shorthand_normal_2"></div>

17 <div id="shorthand_line_height_1"></div>	17 <div id="shorthand_line_height_1"></div>

18 <div id="shorthand_line_height_2"></div>	18 <div id="shorthand_line_height_2"></div>

19 <script>	19 <script>

20 description("Test that line-height in font shorthands cascades correctly.");	20 description("Test that line-height in font shorthands cascades correctly.");

21	21

22 function lineHeight(target) {	22 function lineHeight(target) {

23 return getComputedStyle(target).lineHeight;	23 return getComputedStyle(target).lineHeight;

24 }	24 }

25	25

26 shouldBe("lineHeight(system_font_1)", "'100px'");	26 shouldBe("lineHeight(system_font_1)", "'100px'");

27 shouldBe("lineHeight(system_font_2)", "'normal'");	27 shouldNotBe("lineHeight(system_font_2)", "'100px'");

28 shouldBe("lineHeight(shorthand_normal_1)", "'100px'");	28 shouldBe("lineHeight(shorthand_normal_1)", "'100px'");

29 shouldBe("lineHeight(shorthand_normal_2)", "'normal'");	29 shouldNotBe("lineHeight(shorthand_normal_2)", "'100px'");

30 shouldBe("lineHeight(shorthand_line_height_1)", "'100px'");	30 shouldBe("lineHeight(shorthand_line_height_1)", "'100px'");

31 shouldBe("lineHeight(shorthand_line_height_2)", "'200px'");	31 shouldBe("lineHeight(shorthand_line_height_2)", "'200px'");

32 </script>	32 </script>

OLD	NEW