Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1820753003: [interpreter] Drop overprotective --harmony-instanceof check. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Drop overprotective --harmony-instanceof check. The check in question will trigger because one of our unit tests still emits the bytecode (i.e. unittests/BytecodeArrayBuilderTest) even when the flag is turned on by default. R=rmcilroy@chromium.org TEST=unittests/BytecodeArrayBuilderTest.AllBytecodesGenerated Committed: https://crrev.com/d50d7e18511c9cac1cdea54db6812107ec36a060 Cr-Commit-Position: refs/heads/master@{#34954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/interpreter/bytecode-array-builder.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-21 15:54:26 UTC) #2
rmcilroy
On 2016/03/21 15:54:26, Michael Starzinger wrote: LGTM
4 years, 9 months ago (2016-03-21 15:55:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820753003/1
4 years, 9 months ago (2016-03-21 16:45:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 16:47:17 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 16:48:59 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d50d7e18511c9cac1cdea54db6812107ec36a060
Cr-Commit-Position: refs/heads/master@{#34954}

Powered by Google App Engine
This is Rietveld 408576698