Chromium Code Reviews| Index: appengine/findit/handlers/handlers_util.py |
| diff --git a/appengine/findit/handlers/handlers_util.py b/appengine/findit/handlers/handlers_util.py |
| index 2ef1f17d8af760c01fcb0824f63be62639e0a2d0..ae3ce768edcd50fa200621d5fabc859f93e7d0fe 100644 |
| --- a/appengine/findit/handlers/handlers_util.py |
| +++ b/appengine/findit/handlers/handlers_util.py |
| @@ -146,7 +146,7 @@ def _GetCulpritInfoForTryJobResult(try_job_key, culprits_info): |
| _GetTryJobBuildNumber(try_job_result['url'])) |
| if try_job_result.get('culprit'): |
| try_job_culprits = try_job_result['culprit'] |
| - step = culprit_info['step'] |
| + step = culprit_info.get('step_no_platform', culprit_info['step']) |
|
stgao
2016/03/21 18:01:16
nit: is this a step name or a dict containing info
|
| test = culprit_info['test'] |
| if test == 'N/A': # Only step level. |
| @@ -186,17 +186,22 @@ def _GetCulpritInfoForTryJobResult(try_job_key, culprits_info): |
| culprits_info[key] = test_culprit_info |
| -def _UpdateFlakiness(step_name, failure_key_set, culprits_info): |
| +def _UpdateTryJobCulpritUsingSwarmingTask( |
| + step_name, failure_key_set, culprits_info): |
| for failure_key in failure_key_set: |
| build_keys = failure_key.split('/') |
| task = WfSwarmingTask.Get(*build_keys, step_name=step_name) |
| if not task: |
| continue |
| classified_tests = task.classified_tests |
| + step_no_platform = task.parameters.get( |
| + 'ref_name', step_name.split()[0]) |
| for culprit_info in culprits_info.values(): |
| if (culprit_info['try_job_key'] == failure_key and |
| - culprit_info['test'] in classified_tests.get('flaky_tests', [])): |
| - culprit_info['status'] = FLAKY |
| + step_name == culprit_info['step']): |
| + culprit_info['step_no_platform'] = step_no_platform |
| + if culprit_info['test'] in classified_tests.get('flaky_tests', []): |
| + culprit_info['status'] = FLAKY |
| def GetAllTryJobResults(master_name, builder_name, build_number): |
| @@ -230,7 +235,8 @@ def GetAllTryJobResults(master_name, builder_name, build_number): |
| } |
| step_refering_keys.add(try_job_key) |
| - _UpdateFlakiness(step_name, step_refering_keys, culprits_info) |
| + _UpdateTryJobCulpritUsingSwarmingTask( |
| + step_name, step_refering_keys, culprits_info) |
| try_job_keys.update(step_refering_keys) |
| else: |
| culprits_info[step_name] = { |