Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 1820753002: [Findit] Fix bug when displaying try job result for swamring tests. (Closed)

Created:
4 years, 9 months ago by chanli
Modified:
4 years, 9 months ago
Reviewers:
stgao, lijeffrey
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Fix bug when displaying try job result for swamring tests. The bug is caused by step names with platform. Make sure using step_name without platform when looking for try jobs. BUG=596200 Committed: https://chromium.googlesource.com/infra/infra/+/d355f4edca7dba22111569ff730714ff36e2e8e6

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -59 lines) Patch
M appengine/findit/handlers/handlers_util.py View 1 4 chunks +19 lines, -13 lines 0 comments Download
M appengine/findit/handlers/test/handlers_util_test.py View 1 19 chunks +57 lines, -46 lines 0 comments Download
M appengine/findit/waterfall/test/trigger_swarming_task_pipeline_test.py View 1 chunk +1 line, -0 lines 0 comments Download
M appengine/findit/waterfall/trigger_swarming_task_pipeline.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
chanli
PTAL.
4 years, 9 months ago (2016-03-21 01:02:14 UTC) #2
stgao
lgtm with nits. https://codereview.chromium.org/1820753002/diff/1/appengine/findit/handlers/handlers_util.py File appengine/findit/handlers/handlers_util.py (right): https://codereview.chromium.org/1820753002/diff/1/appengine/findit/handlers/handlers_util.py#newcode149 appengine/findit/handlers/handlers_util.py:149: step = culprit_info.get('step_no_platform', culprit_info['step']) nit: is ...
4 years, 9 months ago (2016-03-21 18:01:17 UTC) #3
lijeffrey
lgtm
4 years, 9 months ago (2016-03-21 18:18:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820753002/20001
4 years, 9 months ago (2016-03-21 18:27:08 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 18:32:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/d355f4edca7dba22111569ff73071...

Powered by Google App Engine
This is Rietveld 408576698