Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 182073002: [webcrypto] Remove code conditional on !defined(WEBCRYPTO_HAS_KEY_ALGORITHM). (Closed)

Created:
6 years, 10 months ago by eroman
Modified:
6 years, 9 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[webcrypto] Remove code conditional on !defined(WEBCRYPTO_HAS_KEY_ALGORITHM). This is the sister change to r253463 to remove the old API once the blink changes have rolled into chromium. BUG=245025 TBR=rsleevi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254080

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -207 lines) Patch
M content/renderer/webcrypto/jwk.cc View 3 chunks +0 lines, -35 lines 0 comments Download
M content/renderer/webcrypto/platform_crypto_nss.cc View 10 chunks +0 lines, -32 lines 0 comments Download
M content/renderer/webcrypto/platform_crypto_openssl.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M content/renderer/webcrypto/shared_crypto.cc View 6 chunks +0 lines, -27 lines 0 comments Download
M content/renderer/webcrypto/shared_crypto_unittest.cc View 21 chunks +0 lines, -45 lines 0 comments Download
M content/renderer/webcrypto/webcrypto_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/webcrypto/webcrypto_util.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/webcrypto/webcrypto_util.cc View 8 chunks +0 lines, -50 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
eroman
This probably won't be ready to land for another 1-2 day (need to wait for ...
6 years, 10 months ago (2014-02-26 20:12:58 UTC) #1
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-02-27 23:34:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/182073002/30001
6 years, 9 months ago (2014-02-27 23:34:57 UTC) #3
Ryan Sleevi
lgtm
6 years, 9 months ago (2014-02-28 00:10:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/182073002/30001
6 years, 9 months ago (2014-02-28 01:16:13 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 10:24:34 UTC) #6
Message was sent while issue was closed.
Change committed as 254080

Powered by Google App Engine
This is Rietveld 408576698