Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: Source/core/animation/Animation.cpp

Issue 182063005: Web Animations API: Refactor IDL input conversion out of Animation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix up includes Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/Animation.cpp
diff --git a/Source/core/animation/Animation.cpp b/Source/core/animation/Animation.cpp
index f77e9f63c8fd9f64bb8adc920520b279b3f28b65..3ca19aab256bf23eff2fc88b3aefab902ea548f4 100644
--- a/Source/core/animation/Animation.cpp
+++ b/Source/core/animation/Animation.cpp
@@ -85,18 +85,6 @@ PassRefPtr<Animation> Animation::create(Element* element, Vector<Dictionary> key
return createUnsafe(element, keyframeDictionaryVector, timingInput);
}
-PassRefPtr<Animation> Animation::create(Element* element, Vector<Dictionary> keyframeDictionaryVector)
-{
- ASSERT(RuntimeEnabledFeatures::webAnimationsAPIEnabled());
-
- // FIXME: This test will not be neccessary once resolution of keyframe values occurs at
- // animation application time.
- if (!checkDocumentAndRenderer(element))
- return nullptr;
-
- return createUnsafe(element, keyframeDictionaryVector);
-}
-
void Animation::setStartDelay(Timing& timing, double startDelay)
{
if (std::isfinite(startDelay))
@@ -309,14 +297,6 @@ PassRefPtr<Animation> Animation::createUnsafe(Element* element, Vector<Dictionar
return create(element, effect, timing);
}
-PassRefPtr<Animation> Animation::createUnsafe(Element* element, Vector<Dictionary> keyframeDictionaryVector)
-{
- RefPtrWillBeRawPtr<KeyframeEffectModel> effect = createKeyframeEffectModel(element, keyframeDictionaryVector);
- Timing timing;
-
- return create(element, effect, timing);
-}
-
Animation::Animation(PassRefPtr<Element> target, PassRefPtrWillBeRawPtr<AnimationEffect> effect, const Timing& timing, Priority priority, PassOwnPtr<EventDelegate> eventDelegate)
: TimedItem(timing, eventDelegate)
, m_target(target)

Powered by Google App Engine
This is Rietveld 408576698