Web Animations API: Refactor IDL input conversion out of Animation

Source/core/animation/Timing.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 19 matching lines @@
 
 #ifndef Timing_h
 #define Timing_h
 
 #include "platform/animation/TimingFunction.h"
 #include "wtf/MathExtras.h"
 #include "wtf/RefPtr.h"
 
 namespace WebCore {
 
+class Dictionary;
+
 struct Timing {
     enum FillMode {
         FillModeAuto,
         FillModeNone,
         FillModeForwards,
         FillModeBackwards,
         FillModeBoth
     };
 
     enum PlaybackDirection {
         PlaybackDirectionNormal,
         PlaybackDirectionReverse,
         PlaybackDirectionAlternate,
         PlaybackDirectionAlternateReverse
     };
 
     Timing()
-        : startDelay(0)
-        , endDelay(0)
-        , fillMode(FillModeAuto)
-        , iterationStart(0)
-        , iterationCount(1)
-        , iterationDuration(std::numeric_limits<double>::quiet_NaN())
-        , playbackRate(1)
-        , direction(PlaybackDirectionNormal)
-        , timingFunction(LinearTimingFunction::create())
+        : startDelay(initialStartDelay())
+        , endDelay(initialEndDelay())
+        , fillMode(initialFillMode())
+        , iterationStart(initialIterationStart())
+        , iterationCount(initialIterationCount())
+        , iterationDuration(initialIterationDuration())
+        , playbackRate(initialPlaybackRate())
+        , direction(initialDirection())
+        , timingFunction(initialTimingFunction())
     {
     }
 
+    Timing(double duration)

[Timothy Loh, 2014/02/28 00:55:24]

I wouldn't add an extra ctor here, just call the regular one and set default.

[esprehn, 2014/02/28 00:57:16]

explicit

[alancutter (OOO until 2018), 2014/03/03 05:09:45]

Done.

+        : startDelay(initialStartDelay())
+        , endDelay(initialEndDelay())
+        , fillMode(initialFillMode())
+        , iterationStart(initialIterationStart())
+        , iterationCount(initialIterationCount())
+        , iterationDuration(duration)
+        , playbackRate(initialPlaybackRate())
+        , direction(initialDirection())
+        , timingFunction(initialTimingFunction())
+    {
+    }
+
+    static double initialStartDelay() { return 0; }

[Timothy Loh, 2014/02/28 00:55:24]

Check with dstockwell here since he does a similar thing in a different way in
crrev.com/178663007.

[dstockwell, 2014/02/28 00:56:37]

I'd rather keep these in the constructor and expose a default instance (like in
my other patch).

[alancutter (OOO until 2018), 2014/03/03 05:09:45]

Done.

+    static double initialEndDelay() { return 0; }
+    static FillMode initialFillMode() { return FillModeAuto; }
+    static double initialIterationStart() { return 0; }
+    static double initialIterationCount() { return 1; }
+    static double initialIterationDuration() { return std::numeric_limits<double>::quiet_NaN(); }
+    static double initialPlaybackRate() { return 1; }
+    static PlaybackDirection initialDirection() { return PlaybackDirectionNormal; }
+    static PassRefPtr<TimingFunction> initialTimingFunction() { return LinearTimingFunction::create(); }
+
+    static Timing convertInput(const Dictionary& timingInputDictionary);

[dstockwell, 2014/02/28 00:56:37]

Timing doesn't need to know anything about input. These should be in
TimingInput.

[alancutter (OOO until 2018), 2014/03/03 05:09:45]

Done.

+    static Timing convertInput(double duration) { return Timing(std::max<double>(duration, 0)); }
+    static Timing convertInput(Timing timing) { return timing; }
+
+    void setStartDelay(double);

[dstockwell, 2014/02/28 00:56:37]

These also belong in TimingInput, it's never valid outside the API bindings to
specify inputs that are coerced.

[alancutter (OOO until 2018), 2014/03/03 05:09:45]

Done.

+    void setEndDelay(double);
+    void setFillMode(const String&);
+    void setIterationStart(double);
+    void setIterationCount(double);
+    void setIterationDuration(double);
+    void setPlaybackRate(double);
+    void setPlaybackDirection(const String&);
+    void setTimingFunction(const String&);
+
     void assertValid() const
     {
         ASSERT(std::isfinite(startDelay));
         ASSERT(std::isfinite(endDelay));
         ASSERT(std::isfinite(iterationStart));
         ASSERT(iterationStart >= 0);
         ASSERT(iterationCount >= 0);
         ASSERT(std::isnan(iterationDuration) || iterationDuration >= 0);
         ASSERT(std::isfinite(playbackRate));
         ASSERT(timingFunction);
     }
 
     double startDelay;
     double endDelay;
     FillMode fillMode;
     double iterationStart;
     double iterationCount;
     double iterationDuration;
     // FIXME: Add activeDuration.
     double playbackRate;
     PlaybackDirection direction;
     RefPtr<TimingFunction> timingFunction;
 };
 
 } // namespace WebCore
 
 #endif