Web Animations API: Refactor IDL input conversion out of Animation

Source/core/animation/ElementAnimation.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef ElementAnimation_h
 #define ElementAnimation_h
 
-#include "wtf/Vector.h"
+#include "RuntimeEnabledFeatures.h"
+#include "core/animation/Animation.h"
+#include "core/animation/DocumentTimeline.h"
+#include "core/animation/Timing.h"
 
 namespace WebCore {
 
-class Animation;
-class Dictionary;
-class Element;
-
 class ElementAnimation {
 public:
-    static Animation* animate(Element&, Vector<Dictionary> keyframesDictionaryVector, Dictionary timingInput);
-    static Animation* animate(Element&, Vector<Dictionary> keyframesDictionaryVector, double timingInput);
-    static Animation* animate(Element&, Vector<Dictionary> keyframesDictionaryVector);
+    template<typename E, typename T = double>
+    static Animation* animate(Element& element, E effect, T timing = Timing::initialIterationDuration())

[dstockwell, 2014/02/27 09:49:36]

Body should stay in cpp.

I think this would work better as:

static Animation* animate(Element& element, E effect)
{
    animate(..., Timing::defaults().iterationDuration);
}

static Animation* animate(Element& element, E effect, T timing)
{
    RefPtr<Animation> animation = Animation::create(&element,
EffectInput::convert(effect), TimingInput::convert(timing));
}

Then we can remove the additional create() functions from Animation and separate
out the different types of input conversion.

[shans, 2014/02/27 20:39:33]

Body can't remain in cpp. This is the joy, the wonder, the brightly illuminating
splendor, of templates.
 

[alancutter (OOO until 2018), 2014/02/28 00:40:22]

AFAICT this is the same as using a default parameter except more code
duplication. Am I wrong in thinking this?
Moved timing input conversion into the Timing class (will be useful for other
timed items that want to make use of the same constructor overloads in future).

Kept effect input conversion in the Animation class, I don't forsee that being
used elsewhere. The Vector<Dictionary> conversion can be moved into
KeyframeEffectModel in a separate patch.

[dstockwell, 2014/02/28 00:56:37]

The result is the same, but it's more readable.
 
I'm trying to keep these concerns separate. Handing input is unrelated to the
model.

[alancutter (OOO until 2018), 2014/03/03 05:09:45]

Done.
Done.

+    {
+        ASSERT(RuntimeEnabledFeatures::webAnimationsAPIEnabled());
+        RefPtr<Animation> animation = Animation::create(&element, effect, timing);
+        element.document().timeline().play(animation.get());
+        return animation.get();
+    }
 };
 
 } // namespace WebCore
 
 #endif // ElementAnimation_h