Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Issue 1820623002: [Media Router] Handle header tooltip when no cast mode host exists. (Closed)

Created:
4 years, 9 months ago by apacible
Modified:
4 years, 9 months ago
Reviewers:
mark a. foltz
CC:
arv+watch_chromium.org, chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Handle header tooltip when no cast mode host exists. Currently, if the cast mode's host is null, the tooltip shows "null". Show no tooltip if the host is null. In non-sink list views, continue to show no tooltip (as expected). BUG=595192 Committed: https://crrev.com/f049e7c0666fe522ea0f0ba3e8eb0f0803d2cd2c Cr-Commit-Position: refs/heads/master@{#382422}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
apacible
PTAL, thanks!
4 years, 9 months ago (2016-03-21 16:41:28 UTC) #4
mark a. foltz
lgtm
4 years, 9 months ago (2016-03-21 20:31:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820623002/20001
4 years, 9 months ago (2016-03-21 21:56:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-03-21 22:44:52 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 22:46:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f049e7c0666fe522ea0f0ba3e8eb0f0803d2cd2c
Cr-Commit-Position: refs/heads/master@{#382422}

Powered by Google App Engine
This is Rietveld 408576698