Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 1820593002: disable SK_SUPPORT_LEGACY_PATHEFFECT_PTR for skia builds (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org, bungeman-skia, dogben
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -13 lines) Patch
M include/core/SkTypes.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/animator/SkDrawDash.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDrawDiscrete.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDrawExtraPathEffect.cpp View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820593002/1
4 years, 9 months ago (2016-03-19 02:05:52 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-19 02:16:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820593002/1
4 years, 9 months ago (2016-03-19 02:17:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/e22bab9954ab378e24d3b04436ac879e35909135
4 years, 9 months ago (2016-03-19 02:18:32 UTC) #10
bungeman-skia
On 2016/03/19 02:18:32, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
4 years, 9 months ago (2016-03-19 21:12:38 UTC) #11
bungeman-skia
4 years, 9 months ago (2016-03-19 21:14:19 UTC) #13
Message was sent while issue was closed.
This is currently making the google3 roll bumpy, not sure what should be done
about it right now though.

Powered by Google App Engine
This is Rietveld 408576698