Expose encrypted_only attribute on VDA supported profiles.

Expose encrypted_only attribute on VDA supported profiles.

This allows us to reduce video playback startup for software codecs
from ~50-300ms (N5..Android One) to ~microseconds.

BUG=596236
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/4708098a8d03f9d0e7b5e6931f9c52c092e78fa9
Cr-Commit-Position: refs/heads/master@{#382185}

[DaleCurtis, 2016-03-18 22:50:31]

Description was changed from

==========
Expose encrypted_only attribute on VDA supported profiles.

This allows us to reduce video playback startup for software codecs
from ~50 to 100ms

BUG=
==========

to

==========
Expose encrypted_only attribute on VDA supported profiles.

This allows us to reduce video playback startup for software codecs
from ~50 to 100ms

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[DaleCurtis, 2016-03-18 22:52:04]

Description was changed from

==========
Expose encrypted_only attribute on VDA supported profiles.

This allows us to reduce video playback startup for software codecs
from ~50 to 100ms

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Expose encrypted_only attribute on VDA supported profiles.

This allows us to reduce video playback startup for software codecs
from ~50-300ms (N5..Android One) to ~microseconds.

BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[DaleCurtis, 2016-03-18 22:52:04]

dalecurtis@chromium.org changed reviewers:
+ kbr@chromium.org, sandersd@chromium.org

[sandersd (OOO until July 31), 2016-03-18 23:19:00]

lgtm

What we really want is a second GpuVideoDecoder at the end of the decoder list
that will ignore this bit, but since we're shipping VPX decoding it's not worth
the effort.

[Ken Russell (switch to Gerrit), 2016-03-19 00:25:36]

lgtm

https://codereview.chromium.org/1820553002/diff/20001/content/common/gpu/medi...
File content/common/gpu/media/android_video_decode_accelerator.cc (right):

https://codereview.chromium.org/1820553002/diff/20001/content/common/gpu/medi...
content/common/gpu/media/android_video_decode_accelerator.cc:1173:
profile.encrypted_only = media::VideoCodecBridge::IsKnownUnaccelerated(
It's a little confusing to readers that the encrypted_only flag would be set to
the return value of a call to a method named IsKnownUnaccelerated.

[DaleCurtis, 2016-03-19 00:29:06]

Thanks for review!

https://codereview.chromium.org/1820553002/diff/20001/content/common/gpu/medi...
File content/common/gpu/media/android_video_decode_accelerator.cc (right):

https://codereview.chromium.org/1820553002/diff/20001/content/common/gpu/medi...
content/common/gpu/media/android_video_decode_accelerator.cc:1173:
profile.encrypted_only = media::VideoCodecBridge::IsKnownUnaccelerated(
On 2016/03/19 at 00:25:36, Ken Russell wrote:
> It's a little confusing to readers that the encrypted_only flag would be set
to the return value of a call to a method named IsKnownUnaccelerated.

Good point. Comment added explaining why this is the case.

[DaleCurtis, 2016-03-19 00:37:38]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2016-03-19 00:37:39]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/1820553002/#ps40001
(title: "Add comment.")

[commit-bot: I haz the power, 2016-03-19 00:38:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1820553002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1820553002/40001

[DaleCurtis, 2016-03-19 00:40:04]

Description was changed from

==========
Expose encrypted_only attribute on VDA supported profiles.

This allows us to reduce video playback startup for software codecs
from ~50-300ms (N5..Android One) to ~microseconds.

BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Expose encrypted_only attribute on VDA supported profiles.

This allows us to reduce video playback startup for software codecs
from ~50-300ms (N5..Android One) to ~microseconds.

BUG=596236
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-19 02:39:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-19 02:39:21]

Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)

[DaleCurtis, 2016-03-19 04:01:47]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2016-03-19 04:01:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1820553002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1820553002/40001

[Ken Russell (switch to Gerrit), 2016-03-19 04:22:44]

On 2016/03/19 02:39:21, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_TIMED_OUT, no
build
> URL)

Please feel free to bypass this builder. Please see http://crbug.com/596250 .

[commit-bot: I haz the power, 2016-03-19 04:54:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-19 05:03:27]

Description was changed from

==========
Expose encrypted_only attribute on VDA supported profiles.

This allows us to reduce video playback startup for software codecs
from ~50-300ms (N5..Android One) to ~microseconds.

BUG=596236
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Expose encrypted_only attribute on VDA supported profiles.

This allows us to reduce video playback startup for software codecs
from ~50-300ms (N5..Android One) to ~microseconds.

BUG=596236
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/4708098a8d03f9d0e7b5e6931f9c52c092e78fa9
Cr-Commit-Position: refs/heads/master@{#382185}
==========

[commit-bot: I haz the power, 2016-03-19 05:03:28]

Patchset 3 (id:??) landed as
https://crrev.com/4708098a8d03f9d0e7b5e6931f9c52c092e78fa9
Cr-Commit-Position: refs/heads/master@{#382185}