Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1820533002:
[MD settings] change side nav text and icon color (Closed)
|
Created:
4 years, 9 months ago by dschuyler Modified:
4 years, 9 months ago CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] change side nav text and icon color
This CL changes the color of the side nav icon and
color text to a slightly lighter grey.
BUG=596143
Committed: https://crrev.com/e233d14c7d5f89defc25a238157cdb58ca22e4d3
Cr-Commit-Position: refs/heads/master@{#382348}
Patch Set 1 #
Total comments: 2
Patch Set 2 : review change #Messages
Total messages: 17 (9 generated)
dschuyler@chromium.org changed reviewers: + dpapad@chromium.org
lgtm
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
also, please regularly check your code, cl descriptions, etc. for typos https://codereview.chromium.org/1820533002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/1820533002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:24: * UX design (bettes@). * UX design (bettes@). */
Description was changed from ========== [MD settings] change side nave text and icon color This CL changes the color of the side nav icon and color text to a slightly lighter grey. BUG=596143 ========== to ========== [MD settings] change side nav text and icon color This CL changes the color of the side nav icon and color text to a slightly lighter grey. BUG=596143 ==========
https://codereview.chromium.org/1820533002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/1820533002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:24: * UX design (bettes@). On 2016/03/18 21:51:52, Dan Beam wrote: > * UX design (bettes@). */ Done.
lgtm
The CQ bit was checked by dschuyler@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org Link to the patchset: https://codereview.chromium.org/1820533002/#ps20001 (title: "review change")
The CQ bit was unchecked by dschuyler@chromium.org
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820533002/20001
Message was sent while issue was closed.
Description was changed from ========== [MD settings] change side nav text and icon color This CL changes the color of the side nav icon and color text to a slightly lighter grey. BUG=596143 ========== to ========== [MD settings] change side nav text and icon color This CL changes the color of the side nav icon and color text to a slightly lighter grey. BUG=596143 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [MD settings] change side nav text and icon color This CL changes the color of the side nav icon and color text to a slightly lighter grey. BUG=596143 ========== to ========== [MD settings] change side nav text and icon color This CL changes the color of the side nav icon and color text to a slightly lighter grey. BUG=596143 Committed: https://crrev.com/e233d14c7d5f89defc25a238157cdb58ca22e4d3 Cr-Commit-Position: refs/heads/master@{#382348} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e233d14c7d5f89defc25a238157cdb58ca22e4d3 Cr-Commit-Position: refs/heads/master@{#382348} |
