Have Node::highestAncestor() return a reference

Have Node::highestAncestor() return a reference

Have Node::highestAncestor() return a reference instead of a pointer as it can
never return null. This makes the calling code look safer.

R=adamk

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167964

[adamk, 2014-02-26 20:37:23]

lgtm, but I'd remove the referenced ASSERT, which imho adds unnecessary clutter.

https://codereview.chromium.org/182053002/diff/1/Source/core/dom/ContainerNode.h
File Source/core/dom/ContainerNode.h (right):

https://codereview.chromium.org/182053002/diff/1/Source/core/dom/ContainerNod...
Source/core/dom/ContainerNode.h:252: ASSERT(highest);
This ASSERT is basically checking that the for loop above is correctly
structured. That doesn't seem worthwhile to me.

[Inactive, 2014-02-26 21:00:01]

https://codereview.chromium.org/182053002/diff/1/Source/core/dom/ContainerNode.h
File Source/core/dom/ContainerNode.h (right):

https://codereview.chromium.org/182053002/diff/1/Source/core/dom/ContainerNod...
Source/core/dom/ContainerNode.h:252: ASSERT(highest);
On 2014/02/26 20:37:23, adamk wrote:
> This ASSERT is basically checking that the for loop above is correctly
> structured. That doesn't seem worthwhile to me.

Done.

[Inactive, 2014-02-26 21:00:05]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-02-26 21:00:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/182053002/40001

[commit-bot: I haz the power, 2014-02-27 03:21:46]

Change committed as 167964