Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 182052: Temporary hack to paper over a rather concerning issue where (Closed)

Created:
11 years, 3 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Temporary hack to paper over a rather concerning issue where ExtensionApiTest appears flaky because it is relying on resources that aren't rebuilt. BUG=19866

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/test/data/extensions/api_test/bookmarks/test.js View 1 chunk +6 lines, -2 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Aaron Boodman
11 years, 3 months ago (2009-09-01 23:46:58 UTC) #1
Matt Perry
11 years, 3 months ago (2009-09-01 23:48:34 UTC) #2
lgtm

http://codereview.chromium.org/182052/diff/1/2
File chrome/test/data/extensions/api_test/bookmarks/test.js (right):

http://codereview.chromium.org/182052/diff/1/2#newcode30
Line 30: // TODO(erikkay): This resource dependency still is working reliably.
s/is/isn't?

Powered by Google App Engine
This is Rietveld 408576698