Issue 182052: Temporary hack to paper over a rather concerning issue where

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 182052: Temporary hack to paper over a rather concerning issue where (Closed)

Created:
11 years, 3 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Temporary hack to paper over a rather concerning issue where ExtensionApiTest appears flaky because it is relying on resources that aren't rebuilt. BUG=19866

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	chrome/test/data/extensions/api_test/bookmarks/test.js	View		1 chunk	+6 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

11 years, 3 months ago (2009-09-01 23:48:34 UTC) #2

lgtm

http://codereview.chromium.org/182052/diff/1/2
File chrome/test/data/extensions/api_test/bookmarks/test.js (right):

http://codereview.chromium.org/182052/diff/1/2#newcode30
Line 30: // TODO(erikkay): This resource dependency still is working reliably.
s/is/isn't?

Expand Messages | Collapse Messages