Delete SkImageDecoder

Delete SkImageDecoder

This image decoding implementation has been replaced
by SkCodec in Android.

Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.

Now we can delete SkImageDecoder :).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820503002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed: https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607

Committed: https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb

Committed: https://skia.googlesource.com/skia/+/f037fdebda2a2626e6512d7532063f2cd41a264d

Committed: https://skia.googlesource.com/skia/+/e8597a4dd07d78eb0e7a45d6502896c1b9a8bfeb

[msarett, 2016-03-18 20:53:37]

Description was changed from

==========
Delete SkImageDecoder

BUG=skia:
==========

to

==========
Delete SkImageDecoder

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

[msarett, 2016-03-21 13:29:34]

Description was changed from

==========
Delete SkImageDecoder

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

to

==========
Delete SkImageDecoder

This image decoding implementation has been replaced
by SkCodec in Android.

Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.

Now we can delete SkImageDecoder :).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

[msarett, 2016-03-21 21:07:36]

msarett@google.com changed reviewers:
+ djsollen@google.com, scroggo@google.com

[msarett, 2016-03-21 21:07:37]

I'm still waiting on 2 CLs in Google3, but I think we can start this review.

I plan to rename all of the SkImageDecoder files to SkImageEncoder in a
follow-up.

[djsollen, 2016-03-22 12:36:58]

are their no GMs that exercise these code paths?  I recall us having GMs for the
texture compression stuff that would also need to be modified or deleted.

Also, for the texture compression formats let's discuss with Leon & Mike if it
is worth porting them over to SkCodec.

[scroggo, 2016-03-22 12:51:27]

On 2016/03/22 12:36:58, djsollen wrote:
> are their no GMs that exercise these code paths?  I recall us having GMs for
the
> texture compression stuff that would also need to be modified or deleted.
> 
> Also, for the texture compression formats let's discuss with Leon & Mike if it
> is worth porting them over to SkCodec.

Matt already ported most of the GMs, but I think you're right - there are still
some that use astc ktx etc. Is it worth porting them over to SkCodec? Yes -
Android has a renewed interest in using astc. Is it worth doing it now? I'm not
convinced that it is. We'll have the history, so we can revive it when needed.

The Android bug is b/25335647. That bug hasn't had any updates in a while,
presumably since the Android team has been focused on features going into N.
That bug is currently marked as a P3, but if they decide they want it for the
next release, we should make sure that we don't hold them back.

[scroggo, 2016-03-22 12:52:54]

> Keep SkMovie

Derek, can we deprecate this? I sincerely doubt that anyone is using it, since
it never worked well, and I know people use other animated GIF implementations.

[msarett, 2016-03-22 15:51:49]

On 2016/03/22 12:51:27, scroggo wrote:
> On 2016/03/22 12:36:58, djsollen wrote:
> > are their no GMs that exercise these code paths?  I recall us having GMs for
> the
> > texture compression stuff that would also need to be modified or deleted.
> > 
> > Also, for the texture compression formats let's discuss with Leon & Mike if
it
> > is worth porting them over to SkCodec.
> 
> Matt already ported most of the GMs, but I think you're right - there are
still
> some that use astc ktx etc. Is it worth porting them over to SkCodec? Yes -
> Android has a renewed interest in using astc. Is it worth doing it now? I'm
not
> convinced that it is. We'll have the history, so we can revive it when needed.
> 
> The Android bug is b/25335647. That bug hasn't had any updates in a while,
> presumably since the Android team has been focused on features going into N.
> That bug is currently marked as a P3, but if they decide they want it for the
> next release, we should make sure that we don't hold them back.

I think this is the right approach.  I've deleted the etc/astc gms and will
plan to restore them when we add this support to SkCodec.

This is also tracked by skbug.com/4971.

[scroggo, 2016-03-22 18:00:04]

LGTM. Yay!

Do we need to wait to make sure that people in Google3 have switched over to
SkCodec/platform decoders before landing? Or do they update manually, so it's
fine to let them handle it when they update Skia? (adding dogben@)

https://codereview.chromium.org/1820503002/diff/50001/gyp/images.gyp
File gyp/images.gyp (left):

https://codereview.chromium.org/1820503002/diff/50001/gyp/images.gyp#oldcode46
gyp/images.gyp:46: # If decoders are added/removed to/from (all/individual)
Maybe this comment is still relevant for SkImageEncoder?

https://codereview.chromium.org/1820503002/diff/50001/src/images/SkImageDecod...
File src/images/SkImageDecoder_libjpeg.cpp (right):

https://codereview.chromium.org/1820503002/diff/50001/src/images/SkImageDecod...
src/images/SkImageDecoder_libjpeg.cpp:31: // this enables our rgb->yuv code,
which is faster than libjpeg on ARM
Wonder if this is true for libjpeg-turbo...

[msarett, 2016-03-22 18:03:59]

On 2016/03/22 18:00:04, scroggo wrote:
> LGTM. Yay!
> 
> Do we need to wait to make sure that people in Google3 have switched over to
> SkCodec/platform decoders before landing? Or do they update manually, so it's
> fine to let them handle it when they update Skia? (adding dogben@)
> 

Yes I think we'll need to wait for Google3.

I'm running a Google3 presubmit which is failing because I'm still waiting on 2
CLs.  I'll verify that the presubmit passes before submitting this.

> https://codereview.chromium.org/1820503002/diff/50001/gyp/images.gyp
> File gyp/images.gyp (left):
> 
> https://codereview.chromium.org/1820503002/diff/50001/gyp/images.gyp#oldcode46
> gyp/images.gyp:46: # If decoders are added/removed to/from (all/individual)
> Maybe this comment is still relevant for SkImageEncoder?
> 
>
https://codereview.chromium.org/1820503002/diff/50001/src/images/SkImageDecod...
> File src/images/SkImageDecoder_libjpeg.cpp (right):
> 
>
https://codereview.chromium.org/1820503002/diff/50001/src/images/SkImageDecod...
> src/images/SkImageDecoder_libjpeg.cpp:31: // this enables our rgb->yuv code,
> which is faster than libjpeg on ARM
> Wonder if this is true for libjpeg-turbo...

[dogben, 2016-03-22 18:04:50]

On 2016/03/22 at 18:03:59, msarett wrote:
> On 2016/03/22 18:00:04, scroggo wrote:
> > LGTM. Yay!
> > 
> > Do we need to wait to make sure that people in Google3 have switched over to
> > SkCodec/platform decoders before landing? Or do they update manually, so
it's
> > fine to let them handle it when they update Skia? (adding dogben@)
> > 
> 
> Yes I think we'll need to wait for Google3.
> 
> I'm running a Google3 presubmit which is failing because I'm still waiting on
2 CLs.  I'll verify that the presubmit passes before submitting this.

:-) Thanks for taking care of this!

[msarett, 2016-03-23 16:50:04]

Derek, any thoughts on the API?

I think the last Google3 fix is about to land, so this almost ready to go.

[djsollen, 2016-03-23 17:12:34]

api lgtm

[msarett, 2016-03-23 17:16:48]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 17:16:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1820503002/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1820503002/50001

[commit-bot: I haz the power, 2016-03-23 17:18:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 17:18:28]

Dry run: Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[msarett, 2016-03-23 17:52:04]

https://codereview.chromium.org/1820503002/diff/50001/gyp/images.gyp
File gyp/images.gyp (left):

https://codereview.chromium.org/1820503002/diff/50001/gyp/images.gyp#oldcode46
gyp/images.gyp:46: # If decoders are added/removed to/from (all/individual)
On 2016/03/22 18:00:04, scroggo wrote:
> Maybe this comment is still relevant for SkImageEncoder?

Agreed.  Done.

https://codereview.chromium.org/1820503002/diff/50001/src/images/SkImageDecod...
File src/images/SkImageDecoder_libjpeg.cpp (right):

https://codereview.chromium.org/1820503002/diff/50001/src/images/SkImageDecod...
src/images/SkImageDecoder_libjpeg.cpp:31: // this enables our rgb->yuv code,
which is faster than libjpeg on ARM
On 2016/03/22 18:00:04, scroggo wrote:
> Wonder if this is true for libjpeg-turbo...

Hmm good question...  Worth thinking about if we start updating our encoders.

[msarett, 2016-03-23 17:53:38]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 17:53:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1820503002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1820503002/70001

[commit-bot: I haz the power, 2016-03-23 17:58:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 17:58:20]

Dry run: Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-CMake-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[msarett, 2016-03-23 18:00:26]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 18:00:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1820503002/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1820503002/90001

[commit-bot: I haz the power, 2016-03-23 18:05:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 18:05:02]

Dry run: Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-CMake-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[msarett, 2016-03-23 18:10:36]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 18:10:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1820503002/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1820503002/110001

[commit-bot: I haz the power, 2016-03-23 18:25:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 18:25:40]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-03-23 18:27:02]

The CQ bit was checked by msarett@google.com

[msarett, 2016-03-23 18:27:03]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com,
djsollen@google.com
Link to the patchset: https://codereview.chromium.org/1820503002/#ps110001
(title: "Cmake fix 2")

[commit-bot: I haz the power, 2016-03-23 18:27:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1820503002/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1820503002/110001

[commit-bot: I haz the power, 2016-03-23 18:28:11]

Description was changed from

==========
Delete SkImageDecoder

This image decoding implementation has been replaced
by SkCodec in Android.

Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.

Now we can delete SkImageDecoder :).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

to

==========
Delete SkImageDecoder

This image decoding implementation has been replaced
by SkCodec in Android.

Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.

Now we can delete SkImageDecoder :).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed:
https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607
==========

[commit-bot: I haz the power, 2016-03-23 18:28:13]

Committed patchset #7 (id:110001) as
https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607

[msarett, 2016-03-23 19:26:15]

A revert of this CL (patchset #7 id:110001) has been created in
https://codereview.chromium.org/1830723002/ by msarett@google.com.

The reason for reverting is: Various problems.

[msarett, 2016-03-23 20:40:06]

Description was changed from

==========
Delete SkImageDecoder

This image decoding implementation has been replaced
by SkCodec in Android.

Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.

Now we can delete SkImageDecoder :).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed:
https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607
==========

to

==========
Delete SkImageDecoder

This image decoding implementation has been replaced
by SkCodec in Android.

Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.

Now we can delete SkImageDecoder :).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed:
https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607
==========

[msarett, 2016-03-23 20:45:01]

PTAL

Deleting the CG and WIC image decoders caused us to stop linking the CG and WIC
image encoders.  I've added code to make sure that we continue to link the CG
and WIC encoders.

[msarett, 2016-03-24 00:52:32]

The CQ bit was checked by msarett@google.com

[msarett, 2016-03-24 00:52:33]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com,
djsollen@google.com
Link to the patchset: https://codereview.chromium.org/1820503002/#ps130001
(title: "Make sure we link CG and WIC encoders")

[commit-bot: I haz the power, 2016-03-24 00:52:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1820503002/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1820503002/130001

[commit-bot: I haz the power, 2016-03-24 01:10:18]

Description was changed from

==========
Delete SkImageDecoder

This image decoding implementation has been replaced
by SkCodec in Android.

Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.

Now we can delete SkImageDecoder :).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed:
https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607
==========

to

==========
Delete SkImageDecoder

This image decoding implementation has been replaced
by SkCodec in Android.

Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.

Now we can delete SkImageDecoder :).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed:
https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607

Committed:
https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb
==========

[commit-bot: I haz the power, 2016-03-24 01:10:20]

Committed patchset #8 (id:130001) as
https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb

[msarett, 2016-03-24 01:52:16]

A revert of this CL (patchset #8 id:130001) has been created in
https://codereview.chromium.org/1828433004/ by msarett@google.com.

The reason for reverting is: Testing the roll - it's still failing.

[msarett, 2016-03-24 02:03:22]

Description was changed from

==========
Delete SkImageDecoder

This image decoding implementation has been replaced
by SkCodec in Android.

Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.

Now we can delete SkImageDecoder :).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed:
https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607

Committed:
https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb
==========

to

==========
Delete SkImageDecoder

This image decoding implementation has been replaced
by SkCodec in Android.

Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.

Now we can delete SkImageDecoder :).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed:
https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607

Committed:
https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb
==========

[msarett, 2016-03-24 02:03:30]

The CQ bit was checked by msarett@google.com

[msarett, 2016-03-24 02:03:30]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com,
djsollen@google.com
Link to the patchset: https://codereview.chromium.org/1820503002/#ps150001
(title: "Include SkRect")

[commit-bot: I haz the power, 2016-03-24 02:03:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1820503002/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1820503002/150001

[commit-bot: I haz the power, 2016-03-24 02:19:31]

Description was changed from

==========
Delete SkImageDecoder

This image decoding implementation has been replaced
by SkCodec in Android.

Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.

Now we can delete SkImageDecoder :).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed:
https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607

Committed:
https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb
==========

to

==========
Delete SkImageDecoder

This image decoding implementation has been replaced
by SkCodec in Android.

Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.

Now we can delete SkImageDecoder :).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed:
https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607

Committed:
https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb

Committed:
https://skia.googlesource.com/skia/+/f037fdebda2a2626e6512d7532063f2cd41a264d
==========

[commit-bot: I haz the power, 2016-03-24 02:19:32]

Committed patchset #9 (id:150001) as
https://skia.googlesource.com/skia/+/f037fdebda2a2626e6512d7532063f2cd41a264d

[msarett, 2016-03-24 11:45:18]

A revert of this CL (patchset #9 id:150001) has been created in
https://codereview.chromium.org/1830943002/ by msarett@google.com.

The reason for reverting is: Roll still failing.

[msarett, 2016-03-24 16:52:56]

Description was changed from

==========
Delete SkImageDecoder

This image decoding implementation has been replaced
by SkCodec in Android.

Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.

Now we can delete SkImageDecoder :).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed:
https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607

Committed:
https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb

Committed:
https://skia.googlesource.com/skia/+/f037fdebda2a2626e6512d7532063f2cd41a264d
==========

to

==========
Delete SkImageDecoder

This image decoding implementation has been replaced
by SkCodec in Android.

Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.

Now we can delete SkImageDecoder :).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed:
https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607

Committed:
https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb

Committed:
https://skia.googlesource.com/skia/+/f037fdebda2a2626e6512d7532063f2cd41a264d
==========

[msarett, 2016-03-24 16:53:20]

The CQ bit was checked by msarett@google.com

[msarett, 2016-03-24 16:53:20]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com,
djsollen@google.com
Link to the patchset: https://codereview.chromium.org/1820503002/#ps170001
(title: "Include SkImage")

[commit-bot: I haz the power, 2016-03-24 16:53:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1820503002/170001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1820503002/170001

[commit-bot: I haz the power, 2016-03-24 17:41:50]

Description was changed from

==========
Delete SkImageDecoder

This image decoding implementation has been replaced
by SkCodec in Android.

Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.

Now we can delete SkImageDecoder :).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed:
https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607

Committed:
https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb

Committed:
https://skia.googlesource.com/skia/+/f037fdebda2a2626e6512d7532063f2cd41a264d
==========

to

==========
Delete SkImageDecoder

This image decoding implementation has been replaced
by SkCodec in Android.

Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.

Now we can delete SkImageDecoder :).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed:
https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607

Committed:
https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb

Committed:
https://skia.googlesource.com/skia/+/f037fdebda2a2626e6512d7532063f2cd41a264d

Committed:
https://skia.googlesource.com/skia/+/e8597a4dd07d78eb0e7a45d6502896c1b9a8bfeb
==========

[commit-bot: I haz the power, 2016-03-24 17:41:52]

Committed patchset #10 (id:170001) as
https://skia.googlesource.com/skia/+/e8597a4dd07d78eb0e7a45d6502896c1b9a8bfeb