Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 18205007: Enable ASAN build (Closed)

Created:
7 years, 5 months ago by borenet
Modified:
7 years, 5 months ago
Reviewers:
epoger, djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Enable ASAN build Requires Clang 3.1 or higher to be installed. R=epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=9891

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M gyp/common_conditions.gypi View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M gyp/common_variables.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A tools/asan_build View 1 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
borenet
7 years, 5 months ago (2013-07-02 20:58:29 UTC) #1
epoger
lgtm https://codereview.chromium.org/18205007/diff/1/tools/asan_build File tools/asan_build (right): https://codereview.chromium.org/18205007/diff/1/tools/asan_build#newcode5 tools/asan_build:5: export CC="$(which clang)" So I guess ASAN builds ...
7 years, 5 months ago (2013-07-02 21:05:40 UTC) #2
borenet
Patch set 2 fixes the gyp options for Mac and addresses comments. This doesn't actually ...
7 years, 5 months ago (2013-07-03 13:30:13 UTC) #3
borenet
Patch set 3 removes Mac support. PTAL.
7 years, 5 months ago (2013-07-03 15:17:07 UTC) #4
epoger
lgtm
7 years, 5 months ago (2013-07-03 15:40:44 UTC) #5
borenet
7 years, 5 months ago (2013-07-03 15:55:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r9891 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698