Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1820493002: Add more documentation for GN header checking (Closed)

Created:
4 years, 9 months ago by brettw
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more documentation for GN header checking Several people have been confused how the header checker works. This significantly expands the documentation. Committed: https://crrev.com/b24c0792cfe4babd048c7ba1d8031b4fd497a811 Cr-Commit-Position: refs/heads/master@{#382106}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+384 lines, -72 lines) Patch
M tools/gn/command_check.cc View 2 chunks +120 lines, -4 lines 0 comments Download
M tools/gn/command_help.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M tools/gn/commands.h View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gn/docs/reference.md View 8 chunks +198 lines, -33 lines 0 comments Download
M tools/gn/header_checker.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M tools/gn/variables.cc View 4 chunks +55 lines, -27 lines 1 comment Download

Messages

Total messages: 11 (5 generated)
brettw
https://codereview.chromium.org/1820493002/diff/1/tools/gn/variables.cc File tools/gn/variables.cc (left): https://codereview.chromium.org/1820493002/diff/1/tools/gn/variables.cc#oldcode483 tools/gn/variables.cc:483: "Expansion of {{bundle_executable_dir}} in create_bundle."; This was on purpose, ...
4 years, 9 months ago (2016-03-18 20:15:05 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820493002/1
4 years, 9 months ago (2016-03-18 20:15:45 UTC) #4
Dirk Pranke
lgtm
4 years, 9 months ago (2016-03-18 21:02:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820493002/1
4 years, 9 months ago (2016-03-18 21:10:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 22:08:52 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 22:09:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b24c0792cfe4babd048c7ba1d8031b4fd497a811
Cr-Commit-Position: refs/heads/master@{#382106}

Powered by Google App Engine
This is Rietveld 408576698