third_party/WebKit/Source/core/layout/api/LayoutItem.h - Issue 1820483002: Untangle multicol coordinate space conversion from offsetFromContainer().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/api/LayoutItem.h

Issue 1820483002: Untangle multicol coordinate space conversion from offsetFromContainer(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address code review comment. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/api/LayoutItem.h

diff --git a/third_party/WebKit/Source/core/layout/api/LayoutItem.h b/third_party/WebKit/Source/core/layout/api/LayoutItem.h

index b0fe64efe4316165e8fd022813bd172cd1e97d10..7a2c18366f83954e46444db9ddd2c9a0733d49fc 100644

--- a/third_party/WebKit/Source/core/layout/api/LayoutItem.h

+++ b/third_party/WebKit/Source/core/layout/api/LayoutItem.h

@@ -139,9 +139,14 @@ public:

return m_layoutObject->styleRef();

}

- LayoutSize offsetFromContainer(const LayoutItem& item, const LayoutPoint& point, bool* offsetDependsOnPoint = nullptr) const

+ LayoutSize offsetFromContainer(const LayoutItem& item) const

{

- return m_layoutObject->offsetFromContainer(item.layoutObject(), point, offsetDependsOnPoint);

+ return m_layoutObject->offsetFromContainer(item.layoutObject());

+ }

+ LayoutSize columnOffset(const LayoutPoint& point) const

+ {

+ return m_layoutObject->columnOffset(point);

}

FrameView* frameView() const

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableCell.cpp ('k') | no next file » | no next file with comments »