Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 1820483002: Untangle multicol coordinate space conversion from offsetFromContainer(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address code review comment. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 513 matching lines...) Expand 10 before | Expand all | Expand 10 after
524 void setOverrideContainingBlockContentLogicalHeight(LayoutUnit); 524 void setOverrideContainingBlockContentLogicalHeight(LayoutUnit);
525 void clearContainingBlockOverrideSize(); 525 void clearContainingBlockOverrideSize();
526 void clearOverrideContainingBlockContentLogicalHeight(); 526 void clearOverrideContainingBlockContentLogicalHeight();
527 527
528 LayoutUnit extraInlineOffset() const; 528 LayoutUnit extraInlineOffset() const;
529 LayoutUnit extraBlockOffset() const; 529 LayoutUnit extraBlockOffset() const;
530 void setExtraInlineOffset(LayoutUnit inlineOffest); 530 void setExtraInlineOffset(LayoutUnit inlineOffest);
531 void setExtraBlockOffset(LayoutUnit blockOffest); 531 void setExtraBlockOffset(LayoutUnit blockOffest);
532 void clearExtraInlineAndBlockOffests(); 532 void clearExtraInlineAndBlockOffests();
533 533
534 LayoutSize offsetFromContainer(const LayoutObject*, const LayoutPoint&, bool * offsetDependsOnPoint = nullptr) const override; 534 LayoutSize offsetFromContainer(const LayoutObject*) const override;
535 535
536 LayoutUnit adjustBorderBoxLogicalWidthForBoxSizing(float width) const; 536 LayoutUnit adjustBorderBoxLogicalWidthForBoxSizing(float width) const;
537 LayoutUnit adjustBorderBoxLogicalHeightForBoxSizing(float height) const; 537 LayoutUnit adjustBorderBoxLogicalHeightForBoxSizing(float height) const;
538 LayoutUnit adjustContentBoxLogicalWidthForBoxSizing(float width) const; 538 LayoutUnit adjustContentBoxLogicalWidthForBoxSizing(float width) const;
539 LayoutUnit adjustContentBoxLogicalHeightForBoxSizing(float height) const; 539 LayoutUnit adjustContentBoxLogicalHeightForBoxSizing(float height) const;
540 540
541 // ComputedMarginValues holds the actual values for margins. It ignores 541 // ComputedMarginValues holds the actual values for margins. It ignores
542 // margin collapsing as they are handled in LayoutBlockFlow. 542 // margin collapsing as they are handled in LayoutBlockFlow.
543 // The margins are stored in logical coordinates (see COORDINATE 543 // The margins are stored in logical coordinates (see COORDINATE
544 // SYSTEMS in LayoutBoxModel) for use during layout. 544 // SYSTEMS in LayoutBoxModel) for use during layout.
(...skipping 597 matching lines...) Expand 10 before | Expand all | Expand 10 after
1142 || breakValue == BreakLeft 1142 || breakValue == BreakLeft
1143 || breakValue == BreakPage 1143 || breakValue == BreakPage
1144 || breakValue == BreakRecto 1144 || breakValue == BreakRecto
1145 || breakValue == BreakRight 1145 || breakValue == BreakRight
1146 || breakValue == BreakVerso; 1146 || breakValue == BreakVerso;
1147 } 1147 }
1148 1148
1149 } // namespace blink 1149 } // namespace blink
1150 1150
1151 #endif // LayoutBox_h 1151 #endif // LayoutBox_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/CaretBase.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698