content/browser/accessibility/browser_accessibility_manager_android.cc - Issue 1820473003: Only the root BrowserAccessibilityManager should destroy the java obj.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_android.cc

Issue 1820473003: Only the root BrowserAccessibilityManager should destroy the java obj. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_create_bam

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_manager_android.cc b/content/browser/accessibility/browser_accessibility_manager_android.cc

index 506448db6e92e777466a7a4dcc483129d83cf63a..4a1b39dc001f2624f6402bb5e8d805d49e0b822c 100644

--- a/content/browser/accessibility/browser_accessibility_manager_android.cc

+++ b/content/browser/accessibility/browser_accessibility_manager_android.cc

@@ -152,7 +152,8 @@ BrowserAccessibilityManagerAndroid::~BrowserAccessibilityManagerAndroid() {

if (obj.is_null())

return;

- Java_BrowserAccessibilityManager_onNativeObjectDestroyed(env, obj.obj());

+ Java_BrowserAccessibilityManager_onNativeObjectDestroyed(

+ env, obj.obj(),reinterpret_cast<intptr_t>(this));

}

// static