Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 1820473002: Conditional AST timing. (Closed)

Created:
4 years, 9 months ago by pquitslund
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Conditional AST timing. Only time AST visitors if `enableTiming` is set. BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/9c3378d56a33c1928a59cbad27e9ffb1c04d4a20

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +9 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
pquitslund
4 years, 9 months ago (2016-03-18 19:52:09 UTC) #3
scheglov
LGTM
4 years, 9 months ago (2016-03-18 19:53:16 UTC) #4
pquitslund
4 years, 9 months ago (2016-03-18 19:58:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9c3378d56a33c1928a59cbad27e9ffb1c04d4a20 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698