Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1820433002: Revert of Templatize SkToXXX. (Closed)

Created:
4 years, 9 months ago by bungeman-skia
Modified:
4 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Templatize SkToXXX. (patchset #2 id:20001 of https://codereview.chromium.org/1814153003/ ) Reason for revert: Chrome does not yet have std::underlying_type. Original issue's description: > Templatize SkToXXX. > > Makes the checked cast in debug more correct, avoiding new > warnings in vs2015. > > BUG=skia:4553 > > Committed: https://skia.googlesource.com/skia/+/0be9e806af72b3e029e691eef5c891c90d3fd320 TBR=reed@google.com,mtklein@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4553 Committed: https://skia.googlesource.com/skia/+/89edf7a95ea694ba2c0a33adedf553c4183cdc19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -247 lines) Patch
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/utils.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkString.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/core/SkTypes.h View 1 chunk +21 lines, -14 lines 0 comments Download
D include/private/SkTFitsIn.h View 1 chunk +0 lines, -227 lines 0 comments Download
M include/private/SkTLogic.h View 4 chunks +4 lines, -3 lines 0 comments Download
M src/core/SkDebug.cpp View 2 chunks +51 lines, -0 lines 0 comments Download
A src/utils/SkTFitsIn.h View 1 chunk +218 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
bungeman-skia
Created Revert of Templatize SkToXXX.
4 years, 9 months ago (2016-03-18 18:53:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820433002/1
4 years, 9 months ago (2016-03-18 18:53:11 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 18:53:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/89edf7a95ea694ba2c0a33adedf553c4183cdc19

Powered by Google App Engine
This is Rietveld 408576698