Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 1820413003: Update allocPageErrorCode only when mmap fails. (Closed)

Created:
4 years, 9 months ago by tasak
Modified:
4 years, 9 months ago
Reviewers:
haraken, tzik
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update allocPageErrorCode only when mmap fails. cluster-fuzz: https://cluster-fuzz.appspot.com/testcase?key=5822916706435072 If mmap fails, blink will immediately crash. So updating allocPageErrorCode when mmap fails is enough to avoid data race. BUG=595631 Committed: https://crrev.com/513bc4519eaf958471a4d169fe3169addfe2f5b3 Cr-Commit-Position: refs/heads/master@{#383052}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/Source/wtf/PageAllocator.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
tasak
Would you review this CL?
4 years, 9 months ago (2016-03-23 11:23:35 UTC) #3
haraken
LGTM
4 years, 9 months ago (2016-03-23 11:24:21 UTC) #4
tzik
lgtm
4 years, 9 months ago (2016-03-23 23:17:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820413003/1
4 years, 9 months ago (2016-03-24 09:32:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 11:09:01 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 11:11:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/513bc4519eaf958471a4d169fe3169addfe2f5b3
Cr-Commit-Position: refs/heads/master@{#383052}

Powered by Google App Engine
This is Rietveld 408576698