Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range.html

Issue 1820403002: Implement Automations for PannerNode and AutioListener (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update test because CL for min/maxValue AudioParam landed Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range.html b/third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range.html
index a917b826248d63ab7b6742429a05b29a398e8702..03a822c867f22ab80d94f392e1a6323bcd8591a8 100644
--- a/third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range.html
+++ b/third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range.html
@@ -9,7 +9,7 @@
<body>
<script>
- description("Test Automation of SpatialListener Position.");
+ description("Test AudioParam Nominal Range Values.");
window.jsTestIsAsync = true;
// Some arbitrary sample rate for the offline context.
@@ -144,6 +144,35 @@
maxValue: mostPositiveFloat
}
}
+ }, {
+ creator: "createPanner",
+ args: [],
+ limits : {
+ positionX: {
+ minValue: -mostPositiveFloat,
+ maxValue: mostPositiveFloat,
+ },
+ positionY: {
+ minValue: -mostPositiveFloat,
+ maxValue: mostPositiveFloat,
+ },
+ positionZ: {
+ minValue: -mostPositiveFloat,
+ maxValue: mostPositiveFloat,
+ },
+ orientationX: {
+ minValue: -mostPositiveFloat,
+ maxValue: mostPositiveFloat,
+ },
+ orientationY: {
+ minValue: -mostPositiveFloat,
+ maxValue: mostPositiveFloat,
+ },
+ orientationZ: {
+ minValue: -mostPositiveFloat,
+ maxValue: mostPositiveFloat,
+ }
+ },
},
// These nodes don't have AudioParams, but we want to test them anyway. Any arguments for the
// constructor are pretty much arbitrary; they just need to be valid.
@@ -175,9 +204,6 @@
creator: "createChannelMerger",
args: [],
}, {
- creator: "createPanner",
- args: [],
- }, {
creator: "createMediaElementSource",
args: [new Audio()]
},{
@@ -206,6 +232,49 @@
})(config));
}
+ // Test the AudioListener params that were added for the automated Panner
+ audit.defineTask("AudioListener", function (done) {
+ testLimits("", context.listener, {
+ positionX: {
+ minValue: -mostPositiveFloat,
+ maxValue: mostPositiveFloat,
+ },
+ positionY: {
+ minValue: -mostPositiveFloat,
+ maxValue: mostPositiveFloat,
+ },
+ positionZ: {
+ minValue: -mostPositiveFloat,
+ maxValue: mostPositiveFloat,
+ },
+ forwardX: {
+ minValue: -mostPositiveFloat,
+ maxValue: mostPositiveFloat,
+ },
+ forwardY: {
+ minValue: -mostPositiveFloat,
+ maxValue: mostPositiveFloat,
+ },
+ forwardZ: {
+ minValue: -mostPositiveFloat,
+ maxValue: mostPositiveFloat,
+ },
+ upX: {
+ minValue: -mostPositiveFloat,
+ maxValue: mostPositiveFloat,
+ },
+ upY: {
+ minValue: -mostPositiveFloat,
+ maxValue: mostPositiveFloat,
+ },
+ upZ: {
+ minValue: -mostPositiveFloat,
+ maxValue: mostPositiveFloat,
+ }
+ });
+ done();
+ });
+
// Verify that we have tested all the create methods available on the context.
audit.defineTask("verifyTests", function (done) {
var allNodes = new Set();

Powered by Google App Engine
This is Rietveld 408576698