Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: third_party/WebKit/Source/platform/audio/EqualPowerPanner.h

Issue 1820403002: Implement Automations for PannerNode and AutioListener (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase UseCounter.h Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/audio/EqualPowerPanner.h
diff --git a/third_party/WebKit/Source/platform/audio/EqualPowerPanner.h b/third_party/WebKit/Source/platform/audio/EqualPowerPanner.h
index 418dd8c7ca858efd29ee2e46e311d81ef1239dd7..d42631673f9288b5b8cfc49db35d69ad4db94abc 100644
--- a/third_party/WebKit/Source/platform/audio/EqualPowerPanner.h
+++ b/third_party/WebKit/Source/platform/audio/EqualPowerPanner.h
@@ -36,19 +36,15 @@ public:
EqualPowerPanner(float sampleRate);
void pan(double azimuth, double elevation, const AudioBus* inputBus, AudioBus* outputBuf, size_t framesToProcess) override;
+ void panWithSampleAccurateValues(double* azimuth, double* elevation, const AudioBus* inputBus, AudioBus* outputBus, size_t framesToProcess) override;
- void reset() override { m_isFirstRender = true; }
+ void reset() override { }
hongchan 2016/05/03 18:15:01 If this doesn't do anything, why it's here?
Raymond Toy 2016/05/03 20:32:21 reset() is abstract virtual function defined in Pa
hongchan 2016/05/03 20:38:58 Got it. Confirmed this is a 'thing' in our chromiu
double tailTime() const override { return 0; }
double latencyTime() const override { return 0; }
private:
- // For smoothing / de-zippering
- bool m_isFirstRender;
- double m_smoothingConstant;
-
- double m_gainL;
- double m_gainR;
+ void calculateDesiredGain(double& desiredGainL, double& desiredGainR, double azimuth, int numberOfChannels);
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698