Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1820373002: S390: [crankshaft] Fixing ES6 tail call elimination. (Closed)

Created:
4 years, 9 months ago by john.yan
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [crankshaft] Fixing ES6 tail call elimination. Port acbb968dedd2b02b5447215a579cf4cdc99bc69a Port 66e22b79e812437aa3be168da4612e64a2de6728 Original commit messages: In case when F inlined normal call to G which tail calls H we should not write translation for G for the tail call site. Otherwise we will see G in a stack trace inside H. This CL also enables all existing tests related to ES6 tail call elimination and adds more combinations. Always generate lazy bailout points for tail calls because Debugger could still require them to inspect optimized frames. R=ishell@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:596473, v8:4698 LOG=N Committed: https://crrev.com/716ab0d3b40d52d45274e4c26702d1bbf448c20b Cr-Commit-Position: refs/heads/master@{#35003}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -10 lines) Patch
M src/crankshaft/s390/lithium-s390.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 4 chunks +35 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820373002/1
4 years, 9 months ago (2016-03-22 17:44:20 UTC) #2
john.yan
PTAL
4 years, 9 months ago (2016-03-22 17:44:35 UTC) #3
JoranSiu
On 2016/03/22 17:44:35, john.yan wrote: > PTAL lgtm
4 years, 9 months ago (2016-03-22 17:49:40 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 18:11:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820373002/1
4 years, 9 months ago (2016-03-22 18:14:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 18:16:06 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 18:16:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/716ab0d3b40d52d45274e4c26702d1bbf448c20b
Cr-Commit-Position: refs/heads/master@{#35003}

Powered by Google App Engine
This is Rietveld 408576698