Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1820353002: Move PDFium libfuzzers to pdf/pdfium/fuzzers. (Closed)

Created:
4 years, 9 months ago by Oliver Chang
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez, raymes, aizatsky
CC:
chromium-reviews, Lei Zhang, Tom Sepez
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PDFium libfuzzers to pdf/pdfium/fuzzers. Also adds a JPX fuzzer. BUG=591789 Committed: https://crrev.com/9741145b1c98047f11ed1b795166ea97ec0829a1 Cr-Commit-Position: refs/heads/master@{#383072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -1876 lines) Patch
M pdf/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
A pdf/pdfium/fuzzers/BUILD.gn View 1 chunk +54 lines, -0 lines 0 comments Download
A pdf/pdfium/fuzzers/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A + pdf/pdfium/fuzzers/dicts/pdf.dict View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pdf/pdfium/fuzzers/dicts/pdf_fm2js.dict View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pdf/pdfium/fuzzers/dicts/pdf_xml.dict View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pdf/pdfium/fuzzers/pdfium_fuzzer.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M testing/libfuzzer/fuzzers/BUILD.gn View 2 chunks +0 lines, -36 lines 0 comments Download
D testing/libfuzzer/fuzzers/dicts/pdf.dict View 1 chunk +0 lines, -1466 lines 0 comments Download
D testing/libfuzzer/fuzzers/dicts/pdf_fm2js.dict View 1 chunk +0 lines, -59 lines 0 comments Download
D testing/libfuzzer/fuzzers/dicts/pdf_xml.dict View 1 chunk +0 lines, -88 lines 0 comments Download
D testing/libfuzzer/fuzzers/pdfium_fuzzer.cc View 1 chunk +0 lines, -222 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Oliver Chang
ptal
4 years, 9 months ago (2016-03-22 17:00:01 UTC) #3
Tom Sepez
On 2016/03/22 17:00:01, Oliver Chang wrote: > ptal Deferring to one of the pdf/OWNERS.
4 years, 9 months ago (2016-03-22 17:36:29 UTC) #4
Oliver Chang
On 2016/03/22 17:36:29, Tom Sepez wrote: > On 2016/03/22 17:00:01, Oliver Chang wrote: > > ...
4 years, 9 months ago (2016-03-22 17:39:16 UTC) #6
aizatsky
lgtm
4 years, 9 months ago (2016-03-22 17:46:29 UTC) #7
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-22 22:04:44 UTC) #9
Oliver Chang
raymes, could you please take a look as an owner of pdf/ ?
4 years, 9 months ago (2016-03-23 17:38:46 UTC) #10
raymes
Sorry for the delay. I don't know anything about fuzzers - but if someone's reviewed ...
4 years, 9 months ago (2016-03-24 00:16:16 UTC) #11
Oliver Chang
On 2016/03/24 00:16:16, raymes wrote: > Sorry for the delay. I don't know anything about ...
4 years, 9 months ago (2016-03-24 00:19:27 UTC) #12
raymes
lgtm!
4 years, 9 months ago (2016-03-24 00:28:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820353002/1
4 years, 9 months ago (2016-03-24 15:26:02 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 16:15:29 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 16:16:20 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9741145b1c98047f11ed1b795166ea97ec0829a1
Cr-Commit-Position: refs/heads/master@{#383072}

Powered by Google App Engine
This is Rietveld 408576698