Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1820333002: Reapply "Remove Code::active_instructions_." (Closed)

Created:
4 years, 9 months ago by rmacnak
Modified:
4 years, 9 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply "Remove Code::active_instructions_." Was reverted because it altered timing and saw a profile tick during deoptimization, fixed in 7e9c892435b03c8fafc25c5694c934f3a4339ab9. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/28846c4bd4ba97e1bce00cf33f700b986a19e4eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M runtime/vm/object.h View 2 chunks +2 lines, -5 lines 0 comments Download
M runtime/vm/object.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/raw_object.cc View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 9 months ago (2016-03-22 17:05:53 UTC) #2
Florian Schneider
lgtm
4 years, 9 months ago (2016-03-22 17:11:12 UTC) #3
rmacnak
4 years, 9 months ago (2016-03-22 17:16:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
28846c4bd4ba97e1bce00cf33f700b986a19e4eb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698