|
|
Created:
4 years, 9 months ago by Igor Sheludko Modified:
4 years, 9 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[es6] Stage tail call elimination.
BUG=v8:4698
LOG=N
Committed: https://crrev.com/4e8670d1fa6c1b059c9524fbb9111e0ceab9d5f2
Cr-Commit-Position: refs/heads/master@{#35007}
Patch Set 1 #Patch Set 2 : Rebasing #Patch Set 3 : Update test262 expectations #
Messages
Total messages: 29 (13 generated)
ishell@chromium.org changed reviewers: + rossberg@chromium.org
PTAL
lgtm
The CQ bit was checked by ishell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820293002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...) v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...) v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...) v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/3331) v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...) v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/15749) v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/3344) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...) v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...) v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/12760)
The CQ bit was checked by ishell@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rossberg@chromium.org Link to the patchset: https://codereview.chromium.org/1820293002/#ps20001 (title: "Rebasing")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820293002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/15750)
hablich@chromium.org changed reviewers: + hablich@chromium.org
lgtm
On 2016/03/22 17:42:02, Hablich wrote: > lgtm wrong issue sorry
adamk@chromium.org changed reviewers: + adamk@chromium.org
You'll need to remove the test262 expectations (since test262 tests run with --harmony enabled).
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820293002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820293002/40001
On 2016/03/22 18:12:01, adamk wrote: > You'll need to remove the test262 expectations (since test262 tests run with > --harmony enabled). Thanks! Trying...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ishell@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rossberg@chromium.org, hablich@chromium.org Link to the patchset: https://codereview.chromium.org/1820293002/#ps40001 (title: "Update test262 expectations")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820293002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820293002/40001
lgtm
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [es6] Stage tail call elimination. BUG=v8:4698 LOG=N ========== to ========== [es6] Stage tail call elimination. BUG=v8:4698 LOG=N Committed: https://crrev.com/4e8670d1fa6c1b059c9524fbb9111e0ceab9d5f2 Cr-Commit-Position: refs/heads/master@{#35007} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4e8670d1fa6c1b059c9524fbb9111e0ceab9d5f2 Cr-Commit-Position: refs/heads/master@{#35007} |