Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1820293002: [es6] Stage tail call elimination. (Closed)

Created:
4 years, 9 months ago by Igor Sheludko
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Stage tail call elimination. BUG=v8:4698 LOG=N Committed: https://crrev.com/4e8670d1fa6c1b059c9524fbb9111e0ceab9d5f2 Cr-Commit-Position: refs/heads/master@{#35007}

Patch Set 1 #

Patch Set 2 : Rebasing #

Patch Set 3 : Update test262 expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -32 lines) Patch
M src/flag-definitions.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M test/test262/test262.status View 1 2 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 29 (13 generated)
Igor Sheludko
PTAL
4 years, 9 months ago (2016-03-22 14:19:16 UTC) #2
rossberg
lgtm
4 years, 9 months ago (2016-03-22 14:26:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820293002/1
4 years, 9 months ago (2016-03-22 16:12:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/15298) v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, ...
4 years, 9 months ago (2016-03-22 16:14:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820293002/20001
4 years, 9 months ago (2016-03-22 16:17:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/15750)
4 years, 9 months ago (2016-03-22 16:34:59 UTC) #12
Michael Hablich
lgtm
4 years, 9 months ago (2016-03-22 17:42:02 UTC) #14
Michael Hablich
On 2016/03/22 17:42:02, Hablich wrote: > lgtm wrong issue sorry
4 years, 9 months ago (2016-03-22 17:42:19 UTC) #15
adamk
You'll need to remove the test262 expectations (since test262 tests run with --harmony enabled).
4 years, 9 months ago (2016-03-22 18:12:01 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820293002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820293002/40001
4 years, 9 months ago (2016-03-22 20:26:00 UTC) #19
Igor Sheludko
On 2016/03/22 18:12:01, adamk wrote: > You'll need to remove the test262 expectations (since test262 ...
4 years, 9 months ago (2016-03-22 20:26:47 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 20:49:13 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820293002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820293002/40001
4 years, 9 months ago (2016-03-22 20:52:22 UTC) #25
Michael Hablich
lgtm
4 years, 9 months ago (2016-03-22 20:53:52 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-22 20:54:25 UTC) #27
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 20:54:41 UTC) #29
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4e8670d1fa6c1b059c9524fbb9111e0ceab9d5f2
Cr-Commit-Position: refs/heads/master@{#35007}

Powered by Google App Engine
This is Rietveld 408576698