Refactor SkBmpCodec

Refactor SkBmpCodec

I started working on indicating the native encoded formats
and things got really complicated for bmp.  I think starting
with this refactor may help a little, and I also think that
this is a good change by itself.

BUG=skia:4133
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820283002

Committed: https://skia.googlesource.com/skia/+/1088db92348baa013511a49392178fccf03e8008

[msarett, 2016-03-22 13:42:35]

Description was changed from

==========
Refactor SkBmpCodec

I started working on indicating the native encoded formats
and things got really complicated for bmp.  I think starting
with this refactor may help a little, and I also think that
this is a good change by itself.

BUG=skia:4133
==========

to

==========
Refactor SkBmpCodec

I started working on indicating the native encoded formats
and things got really complicated for bmp.  I think starting
with this refactor may help a little, and I also think that
this is a good change by itself.

BUG=skia:4133
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-03-22 13:49:03]

msarett@google.com changed reviewers:
+ scroggo@google.com

[msarett, 2016-03-22 13:49:04]

I think I may have caught a bug while writing this CL.  I'll follow up with a
fix if necessary.

https://codereview.chromium.org/1820283002/diff/1/src/codec/SkBmpStandardCode...
File src/codec/SkBmpStandardCodec.cpp (right):

https://codereview.chromium.org/1820283002/diff/1/src/codec/SkBmpStandardCode...
src/codec/SkBmpStandardCodec.cpp:231: if (fInIco && fIsOpaque) {
There shouldn't be a transparency mask if the BMP itself was non-opaque (I
think).

[scroggo, 2016-03-22 15:26:03]

lgtm

[msarett, 2016-03-22 15:46:36]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-03-22 15:46:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1820283002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1820283002/1

[commit-bot: I haz the power, 2016-03-22 15:58:37]

Description was changed from

==========
Refactor SkBmpCodec

I started working on indicating the native encoded formats
and things got really complicated for bmp.  I think starting
with this refactor may help a little, and I also think that
this is a good change by itself.

BUG=skia:4133
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Refactor SkBmpCodec

I started working on indicating the native encoded formats
and things got really complicated for bmp.  I think starting
with this refactor may help a little, and I also think that
this is a good change by itself.

BUG=skia:4133
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/1088db92348baa013511a49392178fccf03e8008
==========

[commit-bot: I haz the power, 2016-03-22 15:58:38]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1088db92348baa013511a49392178fccf03e8008