Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1820263002: [heap] Optimize migration of objects round two (Closed)

Created:
4 years, 9 months ago by Michael Lippautz
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Optimize migration of objects round two * Not jump around all memory to gather whether we need to profile * Cache this information and dispatch to a templatized function BUG=chromium:524425 LOG=N Committed: https://crrev.com/fddd4f06f9d6c75a0017c1ba6f33337d984d76cf Cr-Commit-Position: refs/heads/master@{#34988}

Patch Set 1 #

Patch Set 2 : Removed Heap::MoveBlock #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -34 lines) Patch
M src/heap/heap.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/heap-inl.h View 1 1 chunk +0 lines, -20 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 4 chunks +31 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Michael Lippautz
PTAL Threading the templates all the way through is a major pain as we have ...
4 years, 9 months ago (2016-03-22 12:18:19 UTC) #2
Hannes Payer (out of office)
lgtm
4 years, 9 months ago (2016-03-22 12:24:57 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820263002/20001
4 years, 9 months ago (2016-03-22 12:26:37 UTC) #7
ulan
lgtm
4 years, 9 months ago (2016-03-22 12:32:31 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/12019)
4 years, 9 months ago (2016-03-22 12:41:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820263002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820263002/40001
4 years, 9 months ago (2016-03-22 12:46:24 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-22 13:22:45 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 13:24:07 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fddd4f06f9d6c75a0017c1ba6f33337d984d76cf
Cr-Commit-Position: refs/heads/master@{#34988}

Powered by Google App Engine
This is Rietveld 408576698