Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1820233003: Respect `machineFormat` in package-mode. (Closed)

Created:
4 years, 9 months ago by Paul Berry
Modified:
4 years, 9 months ago
Reviewers:
scheglov, pquitslund
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Respect `machineFormat` in package-mode. Ensures that stats printing in package-mode respects the `machineFormat` flag. (That is, only displays stats if not in machine mode.) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c39a890dd12b17767a4a6e2306848d9c11d66359

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -10 lines) Patch
M pkg/analyzer_cli/lib/src/package_analyzer.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer_cli/test/driver_test.dart View 5 chunks +66 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
This is the same as Phil's CL https://codereview.chromium.org/1818063003/, except that in order to get the ...
4 years, 9 months ago (2016-03-22 19:27:20 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-22 19:30:30 UTC) #3
Paul Berry
4 years, 9 months ago (2016-03-22 20:23:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c39a890dd12b17767a4a6e2306848d9c11d66359 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698