Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 1820163002: Enable embenchen/copy for wasm. (Closed)

Created:
4 years, 9 months ago by bradnelson
Modified:
4 years, 9 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Enable embenchen/copy for wasm. This got fixed by this change: https://crrev.com/32a2ab0c724673961aa145ab63c79a29e6d28fa8 Adding a smaller mjsunit test capturing the issue (was with idiv register allocation). BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=593283 R=aseemgarg@chromium.org,titzer@chromium.org LOG=N TEST=asm-wasm-copy Committed: https://crrev.com/c728dad8b8b83e3109ed8e04333576e466dc0aed Cr-Commit-Position: refs/heads/master@{#35041}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : date #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/wasm/asm-wasm-copy.js View 1 2 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
bradn
4 years, 9 months ago (2016-03-23 17:25:20 UTC) #4
titzer
lgtm
4 years, 9 months ago (2016-03-23 17:27:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820163002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820163002/40001
4 years, 9 months ago (2016-03-23 17:30:15 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-23 17:48:22 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 17:50:12 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c728dad8b8b83e3109ed8e04333576e466dc0aed
Cr-Commit-Position: refs/heads/master@{#35041}

Powered by Google App Engine
This is Rietveld 408576698