Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 182012: Make tips and their links readable in all themes.... (Closed)

Created:
11 years, 3 months ago by Miranda Callahan
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Make tips and their links readable in all themes. BUG= http://crbug.com/20506 TEST= Install any theme. Observe that tips are legible. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24823

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/browser/resources/new_tab_theme.css View 1 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Miranda Callahan
11 years, 3 months ago (2009-08-28 17:19:58 UTC) #1
arv (Not doing code reviews)
LGTM http://codereview.chromium.org/182012/diff/1/2 File chrome/browser/resources/new_tab_theme.css (right): http://codereview.chromium.org/182012/diff/1/2#newcode71 Line 71: color: $8; These color names are really ...
11 years, 3 months ago (2009-08-28 17:44:06 UTC) #2
Miranda Callahan
11 years, 3 months ago (2009-08-28 22:09:27 UTC) #3
Thanks; fixed the issues you addressed and will commit.  I tested with the
removal of "a link" and it works fine for both.

http://codereview.chromium.org/182012/diff/1/2
File chrome/browser/resources/new_tab_theme.css (right):

http://codereview.chromium.org/182012/diff/1/2#newcode71
Line 71: color: $8;
On 2009/08/28 17:44:06, arv wrote:
> These color names are really hard to understand.

Good point; I added comments as above.

http://codereview.chromium.org/182012/diff/1/2#newcode74
Line 74: #tip-line a,
On 2009/08/28 17:44:06, arv wrote:
> I don't think there is a need for both a and a:link. I see we have it above
and
> I believe that is also an error.

Fixed both.

Powered by Google App Engine
This is Rietveld 408576698