Fix memory leask in media yuv_convert unit tests. Replace pointers init'd by ...

media/base/yuv_convert_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/base_paths.h"
 #include "base/file_util.h"
 #include "media/base/yuv_convert.h"
 #include "media/base/yuv_row.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 121 matching lines @@
 
 TEST(YuvScaleTest, YV12) {
   // Read YUV reference data from file.
   FilePath yuv_url;
   EXPECT_TRUE(PathService::Get(base::DIR_SOURCE_ROOT, &yuv_url));
   yuv_url = yuv_url.Append(FILE_PATH_LITERAL("media"))
                    .Append(FILE_PATH_LITERAL("test"))
                    .Append(FILE_PATH_LITERAL("data"))
                    .Append(FILE_PATH_LITERAL("bali.yv12.640_360.yuv"));
   const size_t size_of_yuv = kWidth * kHeight * 12 / 8;  // 12 bpp.
-  uint8* yuv_bytes = new uint8[size_of_yuv];
+  scoped_array<uint8> yuv_bytes(new uint8[size_of_yuv]);

[fbarchard, 2009/08/28 16:56:02]

doh!  How quaint.  This was the first unit test I wrote at google.
Good catch
But, I based it directly on one ralphl wrote, so you'll find at least one more
just like this.
My audio_util one may be similar and needs a check, but I think I'm using
scoped_pointers everywhere.

   EXPECT_EQ(static_cast<int>(size_of_yuv),
             file_util::ReadFile(yuv_url,
-                                reinterpret_cast<char*>(yuv_bytes),
+                                reinterpret_cast<char*>(yuv_bytes.get()),
                                 static_cast<int>(size_of_yuv)));
 
   // Scale a frame of YUV to 32 bit ARGB.
   const size_t size_of_rgb_scaled = kScaledWidth * kScaledHeight * kBpp;
-  uint8* rgb_scaled_bytes = new uint8[size_of_rgb_scaled];
+  scoped_array<uint8> rgb_scaled_bytes(new uint8[size_of_rgb_scaled]);
 
-  media::ScaleYUVToRGB32(yuv_bytes,                             // Y plane
-                         yuv_bytes + kWidth * kHeight,          // U plane
-                         yuv_bytes + kWidth * kHeight * 5 / 4,  // V plane
-                         rgb_scaled_bytes,                      // Rgb output
+  media::ScaleYUVToRGB32(yuv_bytes.get(),                             // Y
+                         yuv_bytes.get() + kWidth * kHeight,          // U
+                         yuv_bytes.get() + kWidth * kHeight * 5 / 4,  // V

[fbarchard, 2009/08/28 16:56:02]

kinda silly that 80 columns forces tiny comments, but this is still readable.

+                         rgb_scaled_bytes.get(),                // Rgb output
                          kWidth, kHeight,                       // Dimensions
                          kScaledWidth, kScaledHeight,           // Dimensions
                          kWidth,                                // YStride
                          kWidth / 2,                            // UvStride
                          kScaledWidth * kBpp,                   // RgbStride
                          media::YV12,
                          media::ROTATE_0);
 
-  unsigned int rgb_hash = hash(rgb_scaled_bytes, size_of_rgb_scaled);
+  unsigned int rgb_hash = hash(rgb_scaled_bytes.get(), size_of_rgb_scaled);
 
   // To get this hash value, run once and examine the following EXPECT_EQ.
   // Then plug new hash value into EXPECT_EQ statements.
 
   // TODO(fbarchard): Make reference code mimic MMX exactly
 #if USE_MMX
   EXPECT_EQ(4259656254u, rgb_hash);
 #else
   EXPECT_EQ(197274901u, rgb_hash);
 #endif
 }
 
 TEST(YuvScaleTest, YV16) {
   // Read YV16 reference data from file.
   FilePath yuv_url;
   EXPECT_TRUE(PathService::Get(base::DIR_SOURCE_ROOT, &yuv_url));
   yuv_url = yuv_url.Append(FILE_PATH_LITERAL("media"))
                    .Append(FILE_PATH_LITERAL("test"))
                    .Append(FILE_PATH_LITERAL("data"))
                    .Append(FILE_PATH_LITERAL("bali.yv16.640_360.yuv"));
   const size_t size_of_yuv = kWidth * kHeight * 16 / 8;  // 16 bpp.
-  uint8* yuv_bytes = new uint8[size_of_yuv];
+  scoped_array<uint8> yuv_bytes(new uint8[size_of_yuv]);
   EXPECT_EQ(static_cast<int>(size_of_yuv),
             file_util::ReadFile(yuv_url,
-                                reinterpret_cast<char*>(yuv_bytes),
+                                reinterpret_cast<char*>(yuv_bytes.get()),
                                 static_cast<int>(size_of_yuv)));
 
   // Scale a frame of YUV to 32 bit ARGB.
   const size_t size_of_rgb_scaled = kScaledWidth * kScaledHeight * kBpp;
-  uint8* rgb_scaled_bytes = new uint8[size_of_rgb_scaled];
+  scoped_array<uint8> rgb_scaled_bytes(new uint8[size_of_rgb_scaled]);
 
-  media::ScaleYUVToRGB32(yuv_bytes,                             // Y plane
-                         yuv_bytes + kWidth * kHeight,          // U plane
-                         yuv_bytes + kWidth * kHeight * 3 / 2,  // V plane
-                         rgb_scaled_bytes,                      // Rgb output
-                         kWidth, kHeight,                       // Dimensions
-                         kScaledWidth, kScaledHeight,           // Dimensions
-                         kWidth,                                // YStride
-                         kWidth / 2,                            // UvStride
-                         kScaledWidth * kBpp,                   // RgbStride
+  media::ScaleYUVToRGB32(yuv_bytes.get(),                             // Y
+                         yuv_bytes.get() + kWidth * kHeight,          // U
+                         yuv_bytes.get() + kWidth * kHeight * 3 / 2,  // V
+                         rgb_scaled_bytes.get(),        // Rgb output
+                         kWidth, kHeight,               // Dimensions
+                         kScaledWidth, kScaledHeight,   // Dimensions
+                         kWidth,                        // YStride
+                         kWidth / 2,                    // UvStride
+                         kScaledWidth * kBpp,           // RgbStride
                          media::YV16,
                          media::ROTATE_0);
 
-  unsigned int rgb_hash = hash(rgb_scaled_bytes, size_of_rgb_scaled);
+  unsigned int rgb_hash = hash(rgb_scaled_bytes.get(), size_of_rgb_scaled);
 
   // To get this hash value, run once and examine the following EXPECT_EQ.
   // Then plug new hash value into EXPECT_EQ statements.
 
   // TODO(fbarchard): Make reference code mimic MMX exactly
 #if USE_MMX
   EXPECT_EQ(974965419u, rgb_hash);
 #else
   EXPECT_EQ(2946450771u, rgb_hash);
 #endif
@@ skipping 28 matching lines @@
                            1, 1,     // Dimensions
                            0,        // YStride
                            0,        // UVStride
                            0,        // RGBStride
                            media::YV12);
 
   int expected_test = memcmp(rgb, expected, sizeof(expected));
   EXPECT_EQ(0, expected_test);
 }