Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 182009: DevTools: call InspectorController.close on detach (Closed)

Created:
11 years, 3 months ago by yurys
Modified:
9 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

DevTools: call InspectorController.close on detach to remove DOM listeners set by the DOM agent. BUG=20482 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24728

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -77 lines) Patch
M webkit/glue/inspector_client_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/glue/inspector_client_impl.cc View 1 2 chunks +10 lines, -74 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
11 years, 3 months ago (2009-08-28 09:45:31 UTC) #1
pfeldman
LG http://codereview.chromium.org/182009/diff/1/3 File webkit/glue/inspector_client_impl.cc (right): http://codereview.chromium.org/182009/diff/1/3#newcode67 Line 67: inspector->setWindowVisible(true); i'd rather fix this in InspectorController. ...
11 years, 3 months ago (2009-08-28 09:50:41 UTC) #2
yurys
11 years, 3 months ago (2009-08-28 09:52:56 UTC) #3
http://codereview.chromium.org/182009/diff/1/3
File webkit/glue/inspector_client_impl.cc (right):

http://codereview.chromium.org/182009/diff/1/3#newcode67
Line 67: inspector->setWindowVisible(true);
On 2009/08/28 09:50:41, pfeldman wrote:
> i'd rather fix this in InspectorController. otherwise, you are hiding this
hack
> even deeper.
This will change once corresponding WebKit change is landed.

http://codereview.chromium.org/182009/diff/1/3#newcode72
Line 72: hideHighlight();
On 2009/08/28 09:50:41, pfeldman wrote:
> please don't change the existing behavior

Done.

Powered by Google App Engine
This is Rietveld 408576698