Issue 182009: DevTools: call InspectorController.close on detach

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 182009: DevTools: call InspectorController.close on detach (Closed)

Created:
11 years, 3 months ago by yurys

Modified:
9 years, 7 months ago

Reviewers:
pfeldman

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: call InspectorController.close on detach to remove DOM listeners set by the DOM agent. BUG=20482 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24728

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -77 lines)			Patch
	M	webkit/glue/inspector_client_impl.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	webkit/glue/inspector_client_impl.cc	View	1	2 chunks	+10 lines, -74 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pfeldman

LG http://codereview.chromium.org/182009/diff/1/3 File webkit/glue/inspector_client_impl.cc (right): http://codereview.chromium.org/182009/diff/1/3#newcode67 Line 67: inspector->setWindowVisible(true); i'd rather fix this in InspectorController. ...

11 years, 3 months ago (2009-08-28 09:50:41 UTC) #2

yurys

11 years, 3 months ago (2009-08-28 09:52:56 UTC) #3

http://codereview.chromium.org/182009/diff/1/3
File webkit/glue/inspector_client_impl.cc (right):

http://codereview.chromium.org/182009/diff/1/3#newcode67
Line 67: inspector->setWindowVisible(true);
On 2009/08/28 09:50:41, pfeldman wrote:
> i'd rather fix this in InspectorController. otherwise, you are hiding this
hack
> even deeper.
This will change once corresponding WebKit change is landed.

http://codereview.chromium.org/182009/diff/1/3#newcode72
Line 72: hideHighlight();
On 2009/08/28 09:50:41, pfeldman wrote:
> please don't change the existing behavior

Done.

Expand Messages | Collapse Messages

Issue 182009: DevTools: call InspectorController.close on detach (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages