Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Issue 1820073003: Update recipes/recipe_modules in build/ for indexing output placeholders by names. (Closed)

Created:
4 years, 9 months ago by stgao
Modified:
4 years, 9 months ago
CC:
chanli, chromium-reviews, infra-reviews+build_chromium.org, Sharu Jiang, kjellander-cc_chromium.org, lijeffrey
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Update recipes/recipe_modules in build/ for indexing output placeholders by names. The CL to index output placeholders by name is https://codereview.chromium.org/1773273003/. BUG=chromium:593198 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299447

Patch Set 1 : . #

Patch Set 2 : Update recipe_modules after change in https://codereview.chromium.org/1785543004/ #

Patch Set 3 : Update legion recipes and expections for referrence to stdout without a placeholder. #

Patch Set 4 : Simplify InputPlaceholder.cleanup #

Patch Set 5 : Roll recipe_engine and depot_tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M infra/config/recipes.cfg View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/api.py View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/legion/__init__.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/legion/api.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/legion/example.expected/basic.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/legion/legion.expected/basic.json View 1 2 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
stgao
PTAL
4 years, 9 months ago (2016-03-22 05:58:17 UTC) #4
iannucci
lgtm
4 years, 9 months ago (2016-03-22 22:24:12 UTC) #5
stgao
+mmeade, would you mind a review of the changes to legion? Is the change expected? ...
4 years, 9 months ago (2016-03-23 05:39:32 UTC) #7
Mike Meade
lgtm
4 years, 9 months ago (2016-03-23 17:52:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820073003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820073003/100001
4 years, 9 months ago (2016-03-23 19:33:26 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 19:37:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299447

Powered by Google App Engine
This is Rietveld 408576698