src/codec/SkIcoCodec.h - Issue 1820073002: Add SkEncodedInfo to report properties of encoded image data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkIcoCodec.h

Issue 1820073002: Add SkEncodedInfo to report properties of encoded image data (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Response to comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkIcoCodec.h

diff --git a/src/codec/SkIcoCodec.h b/src/codec/SkIcoCodec.h

index 9a3f248af5860641bb91e17d5f416ac1b2465644..bd754412d354fe712718e69b56ba64118c668bfa 100644

--- a/src/codec/SkIcoCodec.h

+++ b/src/codec/SkIcoCodec.h

@@ -71,7 +71,7 @@ private:

* Constructor called by NewFromStream

* @param embeddedCodecs codecs for the embedded images, takes ownership

- SkIcoCodec(const SkImageInfo& srcInfo, SkTArray<SkAutoTDelete<SkCodec>, true>* embeddedCodecs);

+ SkIcoCodec(const SkEncodedInfo& info, SkTArray<SkAutoTDelete<SkCodec>, true>* embeddedCodecs);

SkAutoTDelete<SkTArray<SkAutoTDelete<SkCodec>, true>> fEmbeddedCodecs; // owned