GTK Themes: Refresh the entire location bar area on Update().

GTK Themes: Refresh the entire location bar area on Update().

http://crbug.com/20027

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24698

[Evan Stade, 2009-08-27 23:29:32]

http://codereview.chromium.org/182004/diff/1/2
File chrome/browser/gtk/browser_toolbar_gtk.cc (right):

http://codereview.chromium.org/182004/diff/1/2#newcode201
Line 201: location_bar_->AddLocationBarToBox(location_hbox);
I don't like this change. I know we have AddXXXToBox functions in several places
but imo it should be the parent's responsibility to control packing. Why can't
you just do widget()->parent in the LocationBarView?

[Evan Stade, 2009-08-27 23:38:18]

nah, using parent is fine, although you can use gtk_widget_get_parent for
maximum cleanliness

LGTM

[Elliot Glaysher, 2009-08-28 01:18:11]

The first version of the patch did just that, actually. I wasn't
entirely sure if I was touching internal GTK stuff and I'd be
depending on details in a different class, so I decided to make it
more explicit.

Updated.

On Thu, Aug 27, 2009 at 4:29 PM, <estade@chromium.org> wrote:
>
> http://codereview.chromium.org/182004/diff/1/2
> File chrome/browser/gtk/browser_toolbar_gtk.cc (right):
>
> http://codereview.chromium.org/182004/diff/1/2#newcode201
> Line 201: location_bar_->AddLocationBarToBox(location_hbox);
> I don't like this change. I know we have AddXXXToBox functions in
> several places but imo it should be the parent's responsibility to
> control packing. Why can't you just do widget()->parent in the
> LocationBarView?
>
> http://codereview.chromium.org/182004
>