Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 182003002: Don't emit declaration of gl_FragPos unless also changing the origin. (Closed)

Created:
6 years, 10 months ago by bsalomon
Modified:
6 years, 9 months ago
Reviewers:
jvanverth1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Don't emit declaration of gl_FragPos unless also changing the origin. Committed: http://code.google.com/p/skia/source/detail?r=13648

Patch Set 1 #

Patch Set 2 : remove extra assignment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M src/gpu/gl/GrGLShaderBuilder.cpp View 1 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bsalomon
6 years, 10 months ago (2014-02-26 19:46:24 UTC) #1
jvanverth1
lgtm
6 years, 10 months ago (2014-02-26 20:19:26 UTC) #2
bsalomon
On 2014/02/26 20:19:26, JimVV wrote: > lgtm I need to investigate why the ANGLE bot ...
6 years, 10 months ago (2014-02-26 22:26:38 UTC) #3
bsalomon
On 2014/02/26 22:26:38, bsalomon wrote: > On 2014/02/26 20:19:26, JimVV wrote: > > lgtm > ...
6 years, 9 months ago (2014-02-27 19:02:00 UTC) #4
bsalomon
On 2014/02/27 19:02:00, bsalomon wrote: > On 2014/02/26 22:26:38, bsalomon wrote: > > On 2014/02/26 ...
6 years, 9 months ago (2014-03-03 22:21:45 UTC) #5
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 9 months ago (2014-03-03 22:21:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/182003002/20001
6 years, 9 months ago (2014-03-03 22:21:52 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 23:25:32 UTC) #8
Message was sent while issue was closed.
Change committed as 13648

Powered by Google App Engine
This is Rietveld 408576698