Issue 182003: Fix a crash that the reliability bots caught....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 182003: Fix a crash that the reliability bots caught.... (Closed)

Created:
11 years, 3 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com, darin (slow to review), Pam (message me for reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix a crash that the reliability bots caught. This was a silly oops. I had intended to call clearPluginContainer on each WebPluginLoadObserver held in WebPluginContainerImpl's m_pluginLoadObservers array when the WebPluginContainerImpl is destroyed, but I never hooked that up. Here it is. R=jam BUG=10036 TEST=layout test: chrome/plugins/get-url-with-iframe-target-no-crash.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24696

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -2 lines)			Patch
M	webkit/api/src/WebPluginContainerImpl.cpp	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download
A	webkit/data/layout_tests/chrome/plugins/get-url-with-iframe-target-no-crash.html	View		1 chunk	+21 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/chrome/plugins/get-url-with-iframe-target-no-crash-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages