Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1820013002: Remember thread's task when sampling use it when filtering (Closed)

Created:
4 years, 9 months ago by Cutch
Modified:
4 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remember thread's task when sampling use it when filtering R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/a48732a03daae87455ce6a70d589b7fd3d06e730

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -24 lines) Patch
M runtime/vm/profiler.h View 5 chunks +15 lines, -8 lines 0 comments Download
M runtime/vm/profiler.cc View 4 chunks +16 lines, -4 lines 0 comments Download
M runtime/vm/profiler_service.cc View 5 chunks +13 lines, -11 lines 2 comments Download
M runtime/vm/profiler_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/source_report.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
4 years, 9 months ago (2016-03-21 20:13:57 UTC) #3
rmacnak
lgtm https://codereview.chromium.org/1820013002/diff/1/runtime/vm/profiler_service.cc File runtime/vm/profiler_service.cc (right): https://codereview.chromium.org/1820013002/diff/1/runtime/vm/profiler_service.cc#newcode2510 runtime/vm/profiler_service.cc:2510: if (sample->is_allocation_sample()) { return !sample->is_allocation_sample()
4 years, 9 months ago (2016-03-21 21:10:52 UTC) #4
Cutch
Committed patchset #1 (id:1) manually as a48732a03daae87455ce6a70d589b7fd3d06e730 (presubmit successful).
4 years, 9 months ago (2016-03-22 15:42:12 UTC) #6
Cutch
4 years, 9 months ago (2016-03-22 15:42:27 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1820013002/diff/1/runtime/vm/profiler_service.cc
File runtime/vm/profiler_service.cc (right):

https://codereview.chromium.org/1820013002/diff/1/runtime/vm/profiler_service...
runtime/vm/profiler_service.cc:2510: if (sample->is_allocation_sample()) {
On 2016/03/21 21:10:52, rmacnak wrote:
> return !sample->is_allocation_sample()

Done.

Powered by Google App Engine
This is Rietveld 408576698